Bugzilla – Full Text Bug Listing
| Summary: | No prompt after update | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | DJ Houghton <dj.houghton> | ||||
| Component: | p2 | Assignee: | DJ Houghton <dj.houghton> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | john.arthorne, susan, tjwatson | ||||
| Version: | 3.7 | ||||||
| Target Milestone: | 3.7 M3 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
DJ Houghton
The stack trace seems unrelated. We are trying to add a child to a composite repository and the child is malformed so we log an error and continue. I just upgraded from one build to another and didn't get a prompt. (or stack) I'll take a look at this. We'll need to modify ProfileModificationJob to handle the case where a profileid of _SELF_ is handled correctly. Susan, what are your thoughts here? Currently the method looks like this:
public int getRestartPolicy() {
IProfile profile = getSession().getProfileRegistry().getProfile(IProfileRegistry.SELF);
String id = profile == null ? null : profile.getProfileId();
if (id != null && profileId.equals(id))
return restartPolicy;
return ProvisioningJob.RESTART_NONE;
}
And I'm wondering if it is enough to do this:
public int getRestartPolicy() {
if (profileId.equals(IProfileRegistry.SELF))
return restartPolicy;
return ProvisioningJob.RESTART_NONE;
}
I guess the question is: Is there a case where the profileid of the job isn't _SELF_ and we are updating ourselves? Could it be the actual id of the profile?
With the registry lookup code, I'm slightly worried about the case where we are using a build (with a _SELF_ profile id of SDKProfile) to update a different install (with the same profile id). I believe in that case we would be prompted to restart because our profile ids matched.
Created attachment 180520 [details]
Fix v01
Susan, this is a fairly major bug so we are just going to release a fix for the next I-build. Would still appreciate a quick look at the patch when you get a chance, just to make sure we understood the intent of the change you made here. With the patch I am now prompted between updates. Patch released to HEAD. Closing. |