Bugzilla – Full Text Bug Listing
| Summary: | [LTTng] Incorrect compare for LTT_CHANNEL_KERNEL results in drawing more events than intended | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Thomas Gatterweh <thomas_gatterweh> | ||||
| Component: | LinuxTools | Assignee: | Francois Chouinard <fchouinard> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Francois Chouinard <fchouinard> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | patrick.tasse | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 301632 | ||||||
| Attachments: |
|
||||||
Created attachment 180321 [details]
patch file
This bug was for Legacy LTTng which is being removed in Linux Tools 2.0. |
Build Identifier: 0.6.1 In ResourcesBeforeUpdateHandlers.java there are compares in the form // According to Ltt, we should not draw anything if the channel // is the kernel one if (trcEvent.getChannelName().equals( Channels.LTT_CHANNEL_KERNEL)) { return false; } else { However, because the Channels enumeration is not of type String, these compares are useless and will never behave as the comment implies. Instead, the result of the Channel.getInName() function should be compared. Reproducible: Always