Bugzilla – Full Text Bug Listing
| Summary: | [DataBinding] Deprecate binding methods of SWTObservables | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> |
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> |
| Status: | VERIFIED FIXED | QA Contact: | Matthew Hall <qualidafial> |
| Severity: | normal | ||
| Priority: | P3 | CC: | elias, jens, Lars.Vogel, nigelipse, tom.schindl |
| Version: | 3.7 | ||
| Target Milestone: | 4.5 M1 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 435475 | ||
|
Description
Lars Vogel
Adding Tom to get his opinion. Yes - we already have such a thing for EMF in the queue (bug 296147) but couldn't because we had one method not ported to EMFProperties until 2.6M7 (bug 296153) and this would have produced a lot confusion to all users of EMFObservables at a very late point in the cycle I'm for it. Although WidgetProperties still depends on SWTObservables.getRealm so we'd have to move that method somewhere else. Maybe we can deprecate the observe* methods, so that getRealm() can still be used in SWTObservables? If that sounds like a doable thing, I'm happy to provide a Gerrit review request. You might have noticed that the methods have mostly been deprecated in SWTObservables (e4 project) anyway. This was done because the methods took a control that had to be a control of a type that supported the given property. It was not possible to add generics in a clean manner, so each method was split into a different method for each particular control type. Perhaps we need to remove the new methods that replaced the deprecated methods. Marking as WONTFIX. Please reopen if you plan to work on this. I plan to work on the deprecation of the outdated binding methods. For the realm transfer to another class I will open a new bug report. Thanks for taking this on Lars (In reply to Matthew Hall from comment #9) > Thanks for taking this on Lars Fixed with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=75b50bdb237530cda68e2bd80c937b0302c8d8e0 . Hello from the future, Does anyone remember why ViewerObservables wasn't deprecated as part of this change? ViewerObservables seem to have been superseded by ViewerProperties in the same way as SWTObservables was superseded by WidgetProperties. Was there a reason, or was that class simply overlooked? I'm asking because I'm wondering whether ViewerObservables should be updated with type parameters as part of this change: https://bugs.eclipse.org/bugs/show_bug.cgi?id=531748 (In reply to Jens Lideström from comment #12) > Hello from the future, > > Does anyone remember why ViewerObservables wasn't deprecated as part of this > change? > > ViewerObservables seem to have been superseded by ViewerProperties in the > same way as SWTObservables was superseded by WidgetProperties. > > Was there a reason, or was that class simply overlooked? > > I'm asking because I'm wondering whether ViewerObservables should be updated > with type parameters as part of this change: > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=531748 Hello person from the future. :-) I simply overlooked that class, feel free to open a new bug to deprecate that class too > feel free to open a new bug to deprecate that class too I'll do so. ViewersObservables has the method observeDelayedValue that is not in ViewersProperties: https://git.eclipse.org/r/plugins/gitiles/platform/eclipse.platform.ui/+/master/bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/databinding/viewers/ViewersObservables.java?id=6f92cd6dde71e17f0d014c5fe72f89b905ab0de2#66 Since ViewersObservables is a sensible place for that method I'll deprecate only the other methods, not the ViewersObservables class itself. (In reply to Jens Lideström from comment #14) > > feel free to open a new bug to deprecate that class too > > I'll do so. > > ViewersObservables has the method observeDelayedValue that is not in > ViewersProperties: > > https://git.eclipse.org/r/plugins/gitiles/platform/eclipse.platform.ui/+/ > master/bundles/org.eclipse.jface.databinding/src/org/eclipse/jface/ > databinding/viewers/ViewersObservables. > java?id=6f92cd6dde71e17f0d014c5fe72f89b905ab0de2#66 > > Since ViewersObservables is a sensible place for that method I'll deprecate > only the other methods, not the ViewersObservables class itself. Why not adding this method to Viewers Properties? (In reply to Lars Vogel from comment #15) > Why not adding this method to Viewers Properties? Discussion continued at bug 540355. |