Bugzilla – Full Text Bug Listing
| Summary: | [JUnit] Can't run single test with JUnit 4 launcher if there's a suite() method | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Dani Megert <daniel_megert> | ||||
| Component: | UI | Assignee: | Markus Keller <markus.kell.r> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | deepakazad, markus.kell.r, rahuljoshi04 | ||||
| Version: | 3.7 | ||||||
| Target Milestone: | 3.7 M4 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
There are a bunch of slightly different problems when running single JUnit 3 tests with the JUnit 4 runner, depending on whether suite() and/or setUpTest(Test) methods exist and how they are implemented.
It looks like JUnit 4 does not support setUpTest(Test) at all and always runs the suite() method to collect the tests to run. This is a bug in the JUnit 4 Runner (it's not backwards compatible with JUnit 3). Furthermore, the single-method-filter only seems to work if the suite() method returns a simple TestSuite, but not if it uses a TestSetup.
Test case to play with:
import junit.extensions.TestSetup;
public class Sample extends TestCase {
public void test1() {
System.out.println("1");
}
public static Test suite() {
// return new MySetup(new TestSuite(Sample.class), "suite");
return new TestSuite(Sample.class);
}
public static Test setUpTest(Test test) {
return new MySetup(test, "setUpTest");
}
public void test2() {
System.out.println("2");
}
}
class MySetup extends TestSetup {
private final String fName;
public MySetup(Test test, String name) {
super(test);
fName = name;
}
@Override
protected void setUp() throws Exception {
System.out.println("MySetup: " + fName);
}
}
Isn't this a critical/major bug? Currently it is very painful to run a single test from o.e.jdt.ui.tests and o.e.jdt.ui.refactoring.tests. I run a single test by selecting it in outline view and then invoking 'Run as > JUnit plug-in test' from the context menu. By default the JUnit4 runner is chosen as these projects have execution env set to J2SE-1.5. Once the tests are started I stop them, open the launch config and select the JUnit 3 runner and start the test again. This is too many steps... Or is there a workaround that I do not know ? I agree this is painful, but it's nothing new and I didn't have time to dig into it. I'll have a look for M4. Most probably, the fix will have to go into JUnit 4. (In reply to comment #3) > I agree this is painful, but it's nothing new and I didn't have time to dig > into it. > > I'll have a look for M4. Most probably, the fix will have to go into JUnit 4. See also bug 299844. *** Bug 169222 has been marked as a duplicate of this bug. *** The problem is that the "public static Test setUpTest(Test)" is an Eclipse-only functionality and is implemented in JUnit3TestLoader. We need to do something similar in JUnit4TestMethodReference, but that's not trivial because JUnit 4 has so many indirections everywhere and many interesting classes are not API. I have something in the works that should solve the problem, but it needs polish and testing. Created attachment 184667 [details] Fix I gave up adding special support for setUpTest in the JUnit 4 runner. Instead, I just fall back to the JUnit 3 runner when this situation is detected. Testers: Note that the suite() method from comment 0 is invalid, and that it throws an NPE is a bug in org.junit.internal.runners.JUnit38ClassRunner. Fixed in HEAD. (In reply to comment #7) > Created an attachment (id=184667) [details] [diff] > Fix > > I gave up adding special support for setUpTest in the JUnit 4 runner. Instead, > I just fall back to the JUnit 3 runner when this situation is detected. Markus, the launch config still shows JUnit 4, is this deliberate ? I think it is misleading to use JUnit 3 runner internally but show JUnit 4 in the launch config. (In reply to comment #8) > Fixed in HEAD. Thank you!!! Verified in I20101206-1800. > Markus, the launch config still shows JUnit 4, is this deliberate ? I think it > is misleading to use JUnit 3 runner internally but show JUnit 4 in the launch > config. The behavior is correct as it uses the JUnit 4 launcher as indicated in the launch config. How the code is implemented internally (e.g. fall back to JUnit 1 launcher) doesn't matter. |
I20101005-0800. Test Case: Try to run test1 from the following source with the JUnit 4 launcher. import junit.framework.Test; import junit.framework.TestCase; public class Sample extends TestCase { public void test1() { System.out.println("1"); } public static Test suite() { return null; } public void test2() { System.out.println("2"); } }