Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327056

Summary: [disassembly] The view does not update to new context when it is hidden
Product: [Tools] CDT Reporter: Patrick Chuong <pchuong>
Component: cdt-debug-dsfAssignee: Anton Leherbauer <aleherb+eclipse>
Status: RESOLVED FIXED QA Contact: Pawel Piech <pawel.1.piech>
Severity: normal    
Priority: P3 CC: cdtdoug, pawel.1.piech
Version: 7.0   
Target Milestone: 7.0.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Fix aleherb+eclipse: iplog-

Description Patrick Chuong CLA 2010-10-05 22:18:56 EDT
Build Identifier: 201006141710

This only applicable to dsf disassembly view implementation, the cdi disassembly view works as expected.

I believe the difference is the call to IDisassemblyBackend.setDebugContext(), the dsf version callback to gotoFrameIfActive(), where as, the cdi version callback to gotoFrame(). I am not sure whether it is required to check if active or not, maybe for performance issue? If so, than the view will need to perform an update with the current frame when set visible.

Reproducible: Always

Steps to Reproduce:
1. launch a dsf-gdb debug session
2. click on a thread
3. hide the disassembly view behind one of the view, i.e expression
4. click on another thread
5. unhide the disassembly view

Now, the view is still showing the old frame location.
Comment 1 Anton Leherbauer CLA 2010-10-13 09:58:20 EDT
Created attachment 180767 [details]
Fix

Patrick, could you try this patch?
Comment 2 Patrick Chuong CLA 2010-10-13 10:08:38 EDT
(In reply to comment #1)
> Patrick, could you try this patch?

It works as expected.
Comment 3 Anton Leherbauer CLA 2010-10-14 05:19:56 EDT
Thanks, committed to HEAD and cdt_7_0 (7.0.2).