Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 327033

Summary: Workbench doesn't relayout after a stack disappears
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 1.0   
Target Milestone: 4.1 M3   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Clean up the layout handling
none
Updated patch to fix test errors none

Description Remy Suen CLA 2010-10-05 14:44:14 EDT 
If you close all the views of a stack, you just get an empty rectangle of space now. Resizing your window will adjust the layout properly. Note that reopening the views don't help, you still have to resize something to force a layout.
Comment 1 Remy Suen CLA 2010-10-06 09:13:55 EDT 
1. Window > Open Perspective > Debug
2. Activate the 'Debug' view.
3. Close the 'Variables' view.
4. Close the 'Breakpoints' view.
5. You have the empty area (as described by comment 0).
6. Try to resize the horizontal sash splitter of the 'Debug' view and the empty space. You will get an NPE. Whenever the mouse hovers over that area, you will get that NPE.

java.lang.NullPointerException
at org.eclipse.e4.ui.workbench.renderers.swt.SashLayout.adjustWeights(SashLayout.java:172)
at org.eclipse.e4.ui.workbench.renderers.swt.SashLayout$2.mouseMove(SashLayout.java:88)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:205)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4066)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3657)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:693)
Comment 2 Eric Moffatt CLA 2010-10-06 14:07:43 EDT 
Created attachment 180360 [details]
Clean up the layout handling
Comment 3 Eric Moffatt CLA 2010-10-06 14:14:17 EDT 
Created attachment 180361 [details]
Updated patch to fix test errors


Fixes 'forceLayout' to handle MWindows (which are MPSC's).
Comment 4 Eric Moffatt CLA 2010-10-06 14:18:36 EDT 
Committed in >20101006. Applied the patch.
Comment 5 Eric Moffatt CLA 2010-10-26 15:39:13 EDT 
Verified in I20101026-0203.