Bug 327032

Comment 1 Harshana Eranga Martin 2010-10-10 14:43:41 EDT

Created attachment 180566 [details]
Patch for the issue 327032

I have changed the Connect Timeout from 10 secs to 30 seconds since some channels take about 20 seconds before they authorize the access after entering the credentials.

Comment 2 Scott Lewis 2010-10-10 18:58:40 EDT

(In reply to comment #1)
> Created an attachment (id=180566) [details]
> Patch for the issue 327032
> 
> I have changed the Connect Timeout from 10 secs to 30 seconds since some
> channels take about 20 seconds before they authorize the access after entering
> the credentials.

Hi Harshana.  I suggest the following additional change...add the use of a new System property, so that the value can be changed/set...e.g.

	private static final long CONNECT_TIMEOUT = new Long(System.getProperty(
			"org.eclipse.ecf.provider.irc.connectTimeout", "30000"))
			.longValue();


Actually, it would probably be better to introduce a connectTimeout parameter to the IRCRootContainer constructor...and allow the IRCContainerInstantiator to pass in a timeout value...but short of this I would at least suggest the system property above to allow further customization).

Comment 3 Harshana Eranga Martin 2010-10-11 09:22:06 EDT

I'll make this happen. Thanks for the feedback.  

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=180566) [details] [details]
> > Patch for the issue 327032
> > 
> > I have changed the Connect Timeout from 10 secs to 30 seconds since some
> > channels take about 20 seconds before they authorize the access after entering
> > the credentials.
> 
> Hi Harshana.  I suggest the following additional change...add the use of a new
> System property, so that the value can be changed/set...e.g.
> 
>     private static final long CONNECT_TIMEOUT = new Long(System.getProperty(
>             "org.eclipse.ecf.provider.irc.connectTimeout", "30000"))
>             .longValue();
> 
> 
> Actually, it would probably be better to introduce a connectTimeout parameter
> to the IRCRootContainer constructor...and allow the IRCContainerInstantiator to
> pass in a timeout value...but short of this I would at least suggest the system
> property above to allow further customization).

Comment 4 Scott Lewis 2010-10-18 14:27:41 EDT

Harshana...for this addition to make it into ECF 3.4, it will have to be release to git master *this week* (i.e. on or before 10/22/2010).  

If you can't make this schedule then we could easily change the target milestone to ECF 3.5.  So it's your choice...but please do let me (Scott) know what your plans are here.

If you want help with using git/pushing your fixes/additions to the git repo master please let us know via the mailing list or personal email.

Comment 5 Harshana Eranga Martin 2010-10-18 15:55:47 EDT

Hi Scott,

(In reply to comment #4)
> Harshana...for this addition to make it into ECF 3.4, it will have to be
> release to git master *this week* (i.e. on or before 10/22/2010).  
> 
> If you can't make this schedule then we could easily change the target
> milestone to ECF 3.5.  So it's your choice...but please do let me (Scott) know
> what your plans are here.

I'm trying my best to make it to 3.4 release. Change is almost done.
> 
> If you want help with using git/pushing your fixes/additions to the git repo
> master please let us know via the mailing list or personal email.

Yes. I'm having some hard time with git :). I'll send a new mail and join the current conversation.

Comment 6 Scott Lewis 2010-10-18 16:04:03 EDT

(In reply to comment #5)
> Hi Scott,
> 
> (In reply to comment #4)
> > Harshana...for this addition to make it into ECF 3.4, it will have to be
> > release to git master *this week* (i.e. on or before 10/22/2010).  
> > 
> > If you can't make this schedule then we could easily change the target
> > milestone to ECF 3.5.  So it's your choice...but please do let me (Scott) know
> > what your plans are here.
> 
> I'm trying my best to make it to 3.4 release. Change is almost done.
> > 
> > If you want help with using git/pushing your fixes/additions to the git repo
> > master please let us know via the mailing list or personal email.
> 
> Yes. I'm having some hard time with git :). I'll send a new mail and join the
> current conversation.

Short of dealing with the git issues, one option is always to create a patch and attach to this bug...and I or some other committer can release to git master.

Comment 7 Harshana Eranga Martin 2010-10-19 10:14:03 EDT

Created attachment 181181 [details]
This patch contains the UI changes and the Provider changes to support this enhancement. 

This patch contains the UI changes and the Provider changes to support this enhancement. This patch is for CVS. Please apply and verify.

Comment 8 Scott Lewis 2010-10-19 20:24:46 EDT

Thanks Harshana.  I've applied the patches in attachment 181181 [details], smoke tested, and released to master.  Resolving this bug as fixed.  Thanks for getting this done quickly.

Comment 9 Harshana Eranga Martin 2010-10-20 15:22:53 EDT

Hi Scott,

(In reply to comment #8)
> Thanks Harshana.  I've applied the patches in attachment 181181 [details], smoke tested,
> and released to master.  Resolving this bug as fixed.  Thanks for getting this
> done quickly.

Thanks for all the help provided. Wish to see yet another successful ECF release soon.

Comment 10 Harshana Eranga Martin 2011-05-17 03:43:02 EDT

I have increased the default timeout value to 60 seconds and added the same fix I did for IRCChannelContainer to IRCRootContainer as well. 

I have run a set of smoke tests and checked whether there are any regressions because of it. But no regression is reported or identified.