Bugzilla – Full Text Bug Listing
| Summary: | [r-OSGi][RemoteSrvs] Smart Proxy cannot delegate to original method | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [RT] ECF | Reporter: | Markus Kuppe <bugs.eclipse.org> | ||||
| Component: | ecf.protocols | Assignee: | Markus Kuppe <bugs.eclipse.org> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | ||||||
| Version: | 3.3.0 | ||||||
| Target Milestone: | 3.4.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Enhancement released to HEAD (need to file an enhancement request with upstream) Created attachment 180261 [details]
mylyn/context/zip
I've updated the implementation so that if the IFooService inteface happens to declare a _rosgiFoo() method already (rather unlinkely though), that one will be preferred. TODO: add tests to r-osgi test bundle (In reply to comment #1) > Enhancement released to HEAD > (need to file an enhancement request with upstream) https://sourceforge.net/tracker/?func=detail&aid=3085318&group_id=158382&atid=807609 |
A r-OSGi smart proxy [0] allows to intercept methods called on the generated service proxy on the consumer side. E.g. public abstract class SmartProxyService implements IFooService { /* (non-Javadoc) * @see o.e.ecf.IFooService#foo() */ public boolean foo() { return false; } } foo() overwrites the method declaration in IFooService. Unfortunately, r-OSGi does not support calling the original IFooService#foo() method from within the smart proxy, because it's not possible to get hold of the IFooService instance, e.g.: public abstract class SmartProxyService implements IFooService { /* (non-Javadoc) * @see o.e.ecf.IFooService#foo() */ public boolean foo() { return anIFooService.foo(); } } Instead I have added functionality to declare a stub method inside the SmartProxyService that is dispatched to the original IFooService#foo() method at runtime. For this work, the stub method has to be abstract, declare the same signature, but prepend the original method name with "_rosgi" and the first character capitalized: public abstract class SmartProxyService implements IFooService { public abstract boolean _rosgiFoo(); /* (non-Javadoc) * @see o.e.ecf.IFooService#foo() */ public boolean foo() { return _rosgiFoo(); } } [0] http://r-osgi.sourceforge.net/advanced.html