| Summary: | Unable to create menu item: undefined command | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> |
| Component: | IDE | Assignee: | John Arthorne <john.arthorne> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | prakash, pwebster, remy.suen |
| Version: | 3.7 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
|
Description
Dani Megert
John, you removed the commands from 'org.eclipse.ui.ide' (I didn't even know you're a Platform UI committer ;-). Unfortunately your commit comment "merge with HEAD" doesn't say much. It would be good to have a bug # associated with each commit. For now (and the upcoming I-build) I have reverted your change. Probably it was a fix for Bug# 287841? (In reply to comment #2) > Probably it was a fix for Bug# 287841? Might be, though the comment seems wrong then. (In reply to comment #3) > (In reply to comment #2) > > Probably it was a fix for Bug# 287841? > Might be, though the comment seems wrong then. Yes. The comment should be in the right format. Not sure why, but org.eclipse.update.ui/plugin.xml is configured as a binary file. So when John was checking in, he would have missed the binary file warning. That could have been the cause for the omission in the update.ui plugin. John, You also have to move the translated values in the plugin.properties along with the commands & the category. Since the patch is reverted, should we mark this as Resolved and continue the discussion on Bug# 287841 This must have been released accidentally when I was merging changes from the 3.7 stream into the 4.1 stream. I don't even remember having this change in my workspace - it must have been something I started doing a long time ago in my 4.x stream workspace. Thanks for reverting it - that was the right thing to do. |