Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326983

Summary: Unable to create menu item: undefined command
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: IDEAssignee: John Arthorne <john.arthorne>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: prakash, pwebster, remy.suen
Version: 3.7   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Dani Megert CLA 2010-10-05 03:58:56 EDT
N201001004-2000. Works in N201001003-2000.

1. start with new workspace
==>
!SESSION 2010-10-05 09:26:14.662 -----------------------------------------------
eclipse.buildId=N20101004-2000
java.version=1.6.0_23-ea
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=de_CH
Framework arguments:  -keyring c:\eclipse\.keyring -showlocation -application org.eclipse.ui.ide.workbench -testPluginName -classname
Command-line arguments:  -debug -keyring c:\eclipse\.keyring -showlocation -application org.eclipse.ui.ide.workbench -testPluginName -classname -data c:\eclipse\workspaces\tmp

!ENTRY org.eclipse.ui 4 4 2010-10-05 09:26:21.819
!MESSAGE Unable to create menu item "org.eclipse.ui.update.findAndInstallUpdates", command "org.eclipse.ui.update.findAndInstallUpdates" not defined

!ENTRY org.eclipse.ui 4 4 2010-10-05 09:26:21.819
!MESSAGE Unable to create menu item "org.eclipse.ui.update.manageConfiguration", command "org.eclipse.ui.update.manageConfiguration" not defined
Comment 1 Dani Megert CLA 2010-10-05 04:04:55 EDT
John, you removed the commands from 'org.eclipse.ui.ide' (I didn't even know you're a Platform UI committer ;-).

Unfortunately your commit comment "merge with HEAD" doesn't say much. It would be good to have a bug # associated with each commit.

For now (and the upcoming I-build) I have reverted your change.
Comment 2 Prakash Rangaraj CLA 2010-10-05 04:09:26 EDT
Probably it was a fix for Bug# 287841?
Comment 3 Dani Megert CLA 2010-10-05 04:16:14 EDT
(In reply to comment #2)
> Probably it was a fix for Bug# 287841?
Might be, though the comment seems wrong then.
Comment 4 Prakash Rangaraj CLA 2010-10-05 04:24:46 EDT
(In reply to comment #3)
> (In reply to comment #2)
> > Probably it was a fix for Bug# 287841?
> Might be, though the comment seems wrong then.

    Yes. The comment should be in the right format.

    Not sure why, but org.eclipse.update.ui/plugin.xml is configured as a binary file. So when John was checking in, he would have missed the binary file warning. That could have been the cause for the omission in the update.ui plugin.

John, 

    You also have to move the translated values in the plugin.properties along with the commands & the category.

Since the patch is reverted, should we mark this as Resolved and continue the discussion on Bug# 287841
Comment 5 John Arthorne CLA 2010-10-06 14:11:06 EDT
This must have been released accidentally when I was merging changes from the 3.7 stream into the 4.1 stream. I don't even remember having this change in my workspace - it must have been something I started doing a long time ago in my 4.x stream workspace. Thanks for reverting it - that was the right thing to do.