Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326957

Summary: EFSExtensionProvider does not handle URI's correctly
Product: [Tools] CDT Reporter: Greg Watson <g.watson>
Component: cdt-coreAssignee: Vivian Kong <vivkong>
Status: RESOLVED FIXED QA Contact: Doug Schaefer <cdtdoug>
Severity: normal    
Priority: P3 CC: eclipse.sprigogin, recoskie, vivkong
Version: 7.0.1   
Target Milestone: 7.0.2   
Hardware: Macintosh   
OS: Mac OS X   
Whiteboard:
Attachments:
Description Flags
proposed patch for cdt_7_0
none
patch with JUnit tests cdtdoug: iplog-

Description Greg Watson CLA 2010-10-04 14:21:03 EDT 
The EFSExtensionProvider#createNewURIFromPath method assumes that the argument URI contains an authority component that is server based (and hence is composed of user-info, host, and port components). However the URI specification provides for authority components that are either server based or registry based, and so will it fail for these latter types of URIs, particularly if the authority contains unquoted characters.
Comment 1 Vivian Kong CLA 2011-01-25 15:02:20 EST 
Created attachment 187564 [details]
proposed patch for cdt_7_0

Trivial fix
Chris can you please review?
Comment 2 Sergey Prigogin CLA 2011-01-25 15:19:53 EST 
It makes sense to add unit tests for this method.
Comment 3 Vivian Kong CLA 2011-01-25 15:53:30 EST 
Created attachment 187574 [details]
patch with JUnit tests

Patch for cdt_7_0 with JUnit tests
Comment 4 Chris Recoskie CLA 2011-01-26 11:51:03 EST 
The patch seems ok to me.  All the tests pass.
Comment 5 Vivian Kong CLA 2011-01-26 15:00:42 EST 
Fixed in cdt_7_0 and HEAD