Bugzilla – Full Text Bug Listing
| Summary: | IllegalArgumentException resulted in Outline View | ||
|---|---|---|---|
| Product: | [Modeling] TMF | Reporter: | Samantha Chan <chanskw> |
| Component: | Xtext | Assignee: | Jan Koehnlein <jan> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | jan, sebastian.zarnekow, sven.efftinge, tmf.xtext-inbox |
| Version: | 1.0.1 | Flags: | jan:
helios+
sebastian.zarnekow: indigo+ |
| Target Milestone: | M3 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
Samantha Chan
We have to investigate whether the new outline infrastructure suffers from the same issue. Samantha, could you post the transformer code? It would be very helpful to track down this bug. This is the transformer code that causes problem. I commented out all of my transformer code except for this... and I will get into exception.
Just to give you some background:
CompositeDef contains CompositeBody.
CompositeBody contains Clauses
I wanted to filter out the "CompositeBody" object from the outline view. So, I removed filtered it out, and return the clauses as the children of CompositeDef.
public List<EObject> getChildren(CompositeDef typedef) {
List<EObject> children = super.getChildren(typedef);
List<EObject> filtered = new ArrayList<EObject>();
Iterator<EObject> iter = children.iterator();
while(iter.hasNext())
{
EObject obj = iter.next();
if (obj instanceof CompositeBody)
{
List<EObject> caluses = super.getChildNodes(obj);
filtered.addAll(caluses);
}
}
return filtered;
}
I also noticed that if I commented out this code, the compositeDef does not have any children in the outline view.. and may possibly the reason why I do not get any exception.
Also, when the exception happens, the outline view is asking for the "Clauses" feature from a "Block"... which to mean means that there is something wrong with the parsing.
It looks like the problem is the following race condition: The model has changed, but the outline has not been updated yet. When the link with editor mechanism tries to find the outline node to select, it resolves all children of the existing nodes. We are using URIs (in the EObjectHandles) to store the references to the semantic element of an outline node. The default URI fragment paths are fragile with respect to type change. I.e. if a new element of a different EClass takes the same place in the containment reference as the outline node's semantic element, we try to resolve children to an invalid parent. Consequently, we ask for a feature that does not exist on the parent element, causing this exception. I am trying to write a test to reproduce this. Pushed test and fix to Helios_Maintenance: Don't execute anything on EObjectHandleImpl's if the EClass changes. Please verify. This error does not appear in MASTER due to outline redesign. (In reply to comment #5) > Pushed test and fix to Helios_Maintenance: Don't execute anything on > EObjectHandleImpl's if the EClass changes. Please verify. > > This error does not appear in MASTER due to outline redesign. Thanks very much for the prompt response and fix. For planning purpose, when is XText 1.0.2 going to be released? At least with the Helios SR2 release (maybe earlier). Closing all bugs that were set to RESOLVED before Neon.0 Closing all bugs that were set to RESOLVED before Neon.0 |