Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326933

Summary:

eclipse asks for jruby jar every time although I have already pointed the location

Product:

[Tools] MAT

Reporter:

Dimitar Giormov <dimitar.giormov>

Component:

Core

Assignee:

Krum Tsvetkov <krum.tsvetkov>

Status:

CLOSED INVALID

QA Contact:

Severity:

normal

Priority:

CC:

krum.tsvetkov

Version:

1.0

Target Milestone:

---

Hardware:

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
patch that copies the jruby jar in plugins folder	none
cleaned up code and uninstall fix.	none

Description Dimitar Giormov

2010-10-04 11:11:13 EDT

Steps to reproduce:

1. Start Helios
2. install MAT
3. restart Eclipse
4. Point to jruby.jar
5. Restart eclipse

Again install for jruby is requested.

Comment 1 Dimitar Giormov

2010-10-04 11:19:32 EDT

Created attachment 180177 [details]
patch that copies the jruby jar in plugins folder

Comment 2 Krum Tsvetkov

2010-10-06 02:21:03 EDT

Hi Dimitar,

thank you for the patch! I looked at the coding, and also tried it out. 
With the patch the popup doesn't come every time, but it is also not possible to uninstall the jruby bundle any longer - after uninstall the tool still shows that the bundle is available and uses it.

One minor thing - in the FileCopier.getCRC() method the file stream isn't closed.

Could you try to reproduce the uninstall problem?

Comment 3 Dimitar Giormov

2010-11-10 10:16:43 EST

Created attachment 182817 [details]
cleaned up code and uninstall fix.

Comment 4 Dimitar Giormov

2010-11-10 10:17:26 EST

Hi Krum,

here is cleaned up patch with working Uninstall

Comment 5 Krum Tsvetkov

2010-11-11 03:16:52 EST

Hi Dimitar,

thanks for the patch! However, I think that we won't need it any longer. Yesterday I spent some time trying to fully remove the use of jruby and I think I managed to do this. There are still a few things to touch but in general I can get now the same jruby stacktrace just out of the heap objects and not calling the ruby runtime.
I believe this will simplify things a lot - we'll end up with just one class instead of having a separate bundle to take care of the jruby library. Also the build will be simpler.

I will spend a bit more time on this and will write again.

Krum

Comment 6 Krum Tsvetkov

2011-01-12 02:59:46 EST

As the dependency on jruby was fully removed, this bug is now obsolete.