Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326655

Summary: [source lookup] Changing the color of the IP annotation is not reflected immediately in the editor and disassembly
Product: [Tools] CDT Reporter: Anton Leherbauer <aleherb+eclipse>
Component: cdt-debug-edcAssignee: Ken Ryall <ken.ryall>
Status: RESOLVED WONTFIX QA Contact: Ken Ryall <ken.ryall>
Severity: normal    
Priority: P3 CC: pawel.1.piech
Version: 7.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 326145    
Bug Blocks:    
Attachments:
Description Flags
Reuse platform annotation types aleherb+eclipse: iplog-

Description Anton Leherbauer CLA 2010-09-30 06:35:44 EDT
+++ This bug was initially created as a clone of Bug #326145 +++

The color is only applied upon close/reopen of the editor/disassembly.
This might be caused by the duplicate IP annotation type in EDC.

The problem is due to the fact that the preference keys of the annotation types are the same.  There are two solutions:

1) Use unique preference keys
2) Reuse the annotation types from the platform

For DSF I fixed this by 2).  I don't see a good reason to have a separate set of annotation types.
I'll attach a patch which fixes this for EDC as well.
Comment 1 Anton Leherbauer CLA 2010-09-30 06:47:41 EDT
Created attachment 179941 [details]
Reuse platform annotation types

Note that with this fix the class InstructionPointerImageProvider becomes obsolete.
Comment 2 Jonah Graham CLA 2019-12-30 18:39:44 EST
(this is part of a batch change)

The Eclipse CDT EDC (https://wiki.eclipse.org/CDT/cdt-debug-edc) is now obsolete and has not had any active development since 2011. Therefore the still open bugs are being marked as wontfix.

The git repo for the project still exists for posterity at https://git.eclipse.org/c/cdt/org.eclipse.cdt.edc.git/