Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326606

Summary: Base EDC DSF service classes should add implicit class names when registering
Product: [Tools] CDT Reporter: John Cortell <john.cortell>
Component: cdt-debug-edcAssignee: Ken Ryall <ken.ryall>
Status: RESOLVED FIXED QA Contact: Ken Ryall <ken.ryall>
Severity: normal    
Priority: P3 Flags: john.cortell: review? (ken.ryall)
Version: 8.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Solution john.cortell: iplog-

Description John Cortell CLA 2010-09-29 17:52:33 EDT 
I scratched my head for a while trying to figure out why the EDC Registers service wasn't available in my Freescale session. Turns out that in the constructor of my org.eclipse.cdt.debug.edc.services.Registers derivative, I was forgetting to include Register.class.getName() in the list of typenames I pass to the super class.

Easy enough to fix, but it seems to me this is an unnecessary pitfall. The base class should add the implicit service typenames. This not only make things more foolproof, but it simplifies things for the derivative.
Comment 1 John Cortell CLA 2010-09-29 17:53:43 EDT 
Created attachment 179904 [details]
Solution
Comment 2 CDT Genie CLA 2010-09-29 18:23:01 EDT 
*** cdt cvs genie on behalf of jcortell ***
Bug 326606: Base EDC DSF service classes should add implicit class names when registering

[*] DebugServicesFactory.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/launch/DebugServicesFactory.java?root=Tools_Project&r1=1.6&r2=1.7

[*] AbstractTargetEnvironment.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/services/AbstractTargetEnvironment.java?root=Tools_Project&r1=1.3&r2=1.4
[*] AbstractEDCService.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/services/AbstractEDCService.java?root=Tools_Project&r1=1.3&r2=1.4
[*] Stack.java 1.35 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/services/Stack.java?root=Tools_Project&r1=1.34&r2=1.35
[*] Disassembly.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/services/Disassembly.java?root=Tools_Project&r1=1.4&r2=1.5
[*] Registers.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc/src/org/eclipse/cdt/debug/edc/services/Registers.java?root=Tools_Project&r1=1.11&r2=1.12

[*] ARMStack.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.arm/src/org/eclipse/cdt/debug/edc/internal/arm/ARMStack.java?root=Tools_Project&r1=1.10&r2=1.11
[*] ARMRegisters.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.arm/src/org/eclipse/cdt/debug/edc/internal/arm/ARMRegisters.java?root=Tools_Project&r1=1.2&r2=1.3
[*] ARMDisassembly.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.arm/src/org/eclipse/cdt/debug/edc/internal/arm/ARMDisassembly.java?root=Tools_Project&r1=1.5&r2=1.6
[*] TargetEnvironmentARM.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.arm/src/org/eclipse/cdt/debug/edc/internal/arm/TargetEnvironmentARM.java?root=Tools_Project&r1=1.8&r2=1.9

[*] X86Stack.java 1.10 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.x86/src/org/eclipse/cdt/debug/edc/x86/X86Stack.java?root=Tools_Project&r1=1.9&r2=1.10
[*] TargetEnvironmentX86.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.x86/src/org/eclipse/cdt/debug/edc/x86/TargetEnvironmentX86.java?root=Tools_Project&r1=1.2&r2=1.3
[*] X86Registers.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.x86/src/org/eclipse/cdt/debug/edc/x86/X86Registers.java?root=Tools_Project&r1=1.3&r2=1.4
Comment 3 John Cortell CLA 2010-09-30 17:04:02 EDT 
Fixed