Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326594

Summary: [Backport] Lost preference: build only if changes in workspace
Product: [Tools] CDT Reporter: Vivian Kong <vivkong>
Component: cdt-buildAssignee: Vivian Kong <vivkong>
Status: RESOLVED FIXED QA Contact: Andrew Gvozdev <angvoz.dev>
Severity: normal    
Priority: P3 CC: keithc
Version: 7.0.1   
Target Milestone: 7.0.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
proposed patch
none
updated patch cdtdoug: iplog-

Description Vivian Kong CLA 2010-09-29 16:24:11 EDT 
Created attachment 179893 [details]
proposed patch

This is a backport of bug 321778.

The patch for cdt_7_0 is slightly different since we cannot add/change APIs in CDT 7.0.x.  Keith, please take a look and let me know if that works for you.
Comment 1 Keith W. Campbell CLA 2010-09-30 10:32:10 EDT 
Vivian, I don't understand why changes to ACBuilder are included
in the patch: it appears only that private string constants are
inlined.

Other than that, though, the patch looks good to me.
Comment 2 Vivian Kong CLA 2010-09-30 10:43:49 EDT 
Created attachment 179963 [details]
updated patch

(In reply to comment #1)
> Vivian, I don't understand why changes to ACBuilder are included
> in the patch: it appears only that private string constants are
> inlined.
> 
> Other than that, though, the patch looks good to me.

That's because I did a search-and-replace on the patch you attached on bug 321778.  =)  Here's an updated patch.
Comment 3 Keith W. Campbell CLA 2010-09-30 11:01:23 EDT 
I think your first patch would have been fine, but the new one is better.
Comment 4 Vivian Kong CLA 2010-09-30 11:24:34 EDT 
Since we would like to create a patch for this for CDT 7.0.1.  I have created a new branch cdt_7_0_1.

Fixed in cdt_7_0 and cdt_7_0_1.