Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326561

Summary: Tracing tab is the new new dirty button
Product: [Eclipse Project] PDE Reporter: Michael Rennie <Michael_Rennie>
Component: UIAssignee: Curtis Windatt <curtis.windatt.public>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ankur_sharma, curtis.windatt.public
Version: 3.6   
Target Milestone: 3.7 M3   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Michael Rennie CLA 2010-09-29 12:43:06 EDT
I20100928-0800

Open a PDE launch configuration and navigate to the tracing tab, and notice the dirty button becomes enabled. Clicking the revert button does not do anything - and leaves the button enabled.

In my test case I have tracing enabled for one bundle.
Comment 1 Curtis Windatt CLA 2010-09-29 12:49:13 EDT
Confirmed
Comment 2 Ankur Sharma CLA 2010-09-29 14:50:15 EDT
Can you help me with more info? I am using I20100928-1200 and all seems to be working fine for me. However from PDE's view there shouldn't be any difference between the two builds.
Comment 3 Curtis Windatt CLA 2010-09-29 14:58:03 EDT
I have a fix for this one Ankur, it is a bit of luck whether you can reproduce.  What was changing was the selection in the tracing tab.  The config actually saves the current selection as a config attribute, if the selection isn't set properly (happens sometimes when you first open the dialog/tab) the attributes don't match up.
Comment 4 Curtis Windatt CLA 2010-09-29 15:31:19 EDT
Fixed in HEAD.  See TracingBlock.java.  The selected item is now stored in dialog settings instead of an attribute.  I deprecated the attribute (as the constant key is api).
Comment 5 Curtis Windatt CLA 2010-10-27 14:08:56 EDT
Verified in I20101027-0800