Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326504

Summary: [patch] useless composite in NewNodeDialog.createDialogArea
Product: [Eclipse Project] Equinox Reporter: Martin Monperrus <martin.monperrus>
Component: SecurityAssignee: Oleg Besedin <ob1.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: ob1.eclipse, tjwatson
Version: unspecified   
Target Milestone: 3.7 M3   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch
ob1.eclipse: iplog+
Updated patch none

Description Martin Monperrus CLA 2010-09-29 05:47:53 EDT
Build Identifier: 

There is a muddle of new, super and returned Composite in NewNodeDialog.createDialogArea. A patch is attached.

Best regards, --Martin




Reproducible: Always
Comment 1 Martin Monperrus CLA 2010-09-29 05:48:26 EDT
Created attachment 179817 [details]
patch

patch
Comment 2 Thomas Watson CLA 2010-09-29 08:45:21 EDT
Thanks Martin,

Oleg, I am not familiar with this.  Does this patch look good?
Comment 3 Oleg Besedin CLA 2010-09-29 09:45:19 EDT
Created attachment 179842 [details]
Updated patch

(In reply to comment #2)
> Oleg, I am not familiar with this.  Does this patch look good?

Yes, it looks good. I'll update bundle versions as well.
Comment 4 Oleg Besedin CLA 2010-09-29 09:46:35 EDT
Patch applied to CVS Head. Thanks Martin!
Comment 5 Martin Monperrus CLA 2010-10-01 05:58:31 EDT
Thanks for answering so fast :-)
--Martin