Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326490

Summary: [tcf] Add authentication to the TCF connector service
Product: [Tools] TCF Reporter: Anna Dushistova <anna.dushistova>
Component: CoreAssignee: Anna Dushistova <anna.dushistova>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: cdtdoug, liping.ke
Version: unspecified   
Target Milestone: 0.4.0   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
Add authentication to the TCF connector service
none
Add authentication to the TCF connector service
none
Add authentication to the TCF connector service anna.dushistova: iplog+, anna.dushistova: review+

Description Anna Dushistova CLA 2010-09-29 04:03:35 EDT
See bug 246987 for details.
Comment 1 Liping Ke CLA 2010-09-30 09:09:09 EDT
Created attachment 179949 [details]
Add authentication to the TCF connector service

Make TCF connector service become credential connection
Comment 2 Liping Ke CLA 2010-09-30 09:12:05 EDT
Hi, 

This patch is to make TCF connector service become an authenticated connection.
We can simply enable the password dialog prompt by inherit
StandardConnectorService superclass which provides all needed services such
username/password input UIs.
And also, we create a property set which are needed in later shells service
login process. ( we need to know command prompt chars, etc).

And also, since we're on national day leave from Oct.1 to Oct.7, email access will be slower.

Thanks a lot!
Regards,
criping
Comment 3 Anna Dushistova CLA 2010-10-05 18:22:49 EDT
This works as expected. Would be nice of you to reuse existing Messages.java/Messages.properties instead of creating your own. And also, could you please post the legal disclaimer here as well?
After you do these two things I'll be happy to apply your patch.
Thanks!
Comment 4 Liping Ke CLA 2010-10-07 21:17:50 EDT
Hi, Anna
I will modify the patch per your request, test the patch with newer RSE code.
Then resend the patch to you.

Thanks & Regards,
criping
Comment 5 Liping Ke CLA 2010-10-07 22:31:35 EDT
Created attachment 180467 [details]
Add authentication to the TCF connector service

Legal Message: I, Liping Ke, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. {I am authorized by my employer (Intel Corp.) to make this
contribution under the EPL.}

Hi, Anna

I rebased the patch on svn trunk latest revision r1178 (Our project use 0.3.0 tag version, after all patches are pulled in, we'll switch to newer revision too). And I use Message.properties as your suggestion. And I have tested on the latest trunk.

This is the 1st patch (three in total). I'd like to submit the patches one by one so that I can easily verify each patch with latest trunk:)

Any other problem, just let me know.

Thanks& Regards,
criping
Comment 6 Anna Dushistova CLA 2010-10-08 07:29:31 EDT
Could you also please modify the copyright headers in all 3 files accordingly?
Thanks!
Comment 7 Liping Ke CLA 2010-10-08 22:50:24 EDT
Created attachment 180537 [details]
Add authentication to the TCF connector service

Hi, Anna

I add Intel Corp. to copyright headers in all three files.

Thanks a lot!
criping
Comment 8 Anna Dushistova CLA 2010-10-11 15:18:00 EDT
Comment on attachment 180537 [details]
Add authentication to the TCF connector service

Patch is applied to trunk. Thanks!
Comment 9 Anna Dushistova CLA 2010-10-11 15:18:48 EDT
Closing.
Comment 10 Doug Schaefer CLA 2011-05-17 10:49:49 EDT
Moving bugs to new home for IP log.
Comment 11 Martin Oberhuber CLA 2013-06-05 06:27:20 EDT
Bulk change: Marking all bugs from the TM era (until June 2011) target 0.3