Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326302

Summary:	retain dirty state of editor when refreshing automatically
Product:	z_Archived	Reporter:	Artur Kronenberg <artur.kronenberg>
Component:	Mylyn	Assignee:	Project Inbox <mylyn-triaged>
Status:	CLOSED MOVED	QA Contact:
Severity:	normal
Priority:	P3	CC:	robert.elves, steffen.pingel
Version:	unspecified
Target Milestone:	---
Hardware:	Macintosh
OS:	Mac OS X
Whiteboard:

Description Artur Kronenberg

2010-09-27 09:34:45 EDT

Hi,

I saw that, when I open a bug, check "Add self to cc" (Don't hit submit), then click on creating an attachment, choose a patch, fill in the wizard and hit finish, the patch/comment/description is submitted while the email address is not added to the cc list. 

So after submitting a patch, I have to hit submit a second time, to add myself to the cc list. The tooling should probably realize when the "Add self to cc" box is checked and submit that information as well.

Kind regards,
Artur

Comment 1 Steffen Pingel

2010-09-27 13:52:27 EDT

The attachment dialog works independently of the task editor, i.e. outgoing changes in the editor are not submitted when attaching files. The reason is that the workflow is not embedded in the editor and hence submitting the task could perceived as an unintended side effect. Does that make sense?

Comment 2 Artur Kronenberg

2010-09-28 07:10:35 EDT

(In reply to comment #1)
> The attachment dialog works independently of the task editor, i.e. outgoing
> changes in the editor are not submitted when attaching files. The reason is
> that the workflow is not embedded in the editor and hence submitting the task
> could perceived as an unintended side effect. Does that make sense?

If it's meant to be this way, that's fine. However, if I submit a patch and my editor was marked dirty before, after submitting, the editor is not dirty anymore. So my changes in the editor don't get submitted but simply disappear. So from my view it seems like my editor changes actually do get submitted (hence the dirty flag is gone) but they are not.

Comment 3 Steffen Pingel

2010-09-28 13:38:48 EDT

(In reply to comment #2)
> If it's meant to be this way, that's fine. However, if I submit a patch and my
> editor was marked dirty before, after submitting, the editor is not dirty
> anymore. So my changes in the editor don't get submitted but simply disappear.
> So from my view it seems like my editor changes actually do get submitted (hence
> the dirty flag is gone) but they are not.

Thanks for pointing this out. I can see how that is unexpected. The automatic refresh after the attachment submission causes it to get saved. Unfortunately there is no simple workaround or change to address that. 

For now I can only recommend to check for outgoing tasks in the task list to track unsubmitted changes.

I'll keep this bug open to track this problem. Fixing it would require involved changes to the task editor model so we won't be able to consider it in the short term.

Comment 4 Eclipse Webmaster

2022-11-15 11:45:08 EST

Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn