Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326257

Summary: [PropertiesView] LabelProvider can not be disposed in the property source.
Product: [Eclipse Project] Platform Reporter: Maksym Bykovskyy <bykovskyy.maksym>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3    
Version: 3.6   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard: stalebug

Description Maksym Bykovskyy CLA 2010-09-26 09:13:22 EDT
Build Identifier: 20100617-1415

Property source needs a dispose() method, because label providers created in the constructor cannot be disposed. Label providers that create resources like Image introduce memory leaks.

Reproducible: Always
Comment 1 Francis Upton IV CLA 2010-11-03 03:56:00 EDT
Sorry, but what's a property source? Can you give me a class name?
Comment 2 Maksym Bykovskyy CLA 2010-11-03 05:28:41 EDT
By property source I mean anything that implements IPropertySource. You see it appears that a new instance of IPropertySource is created each time selection changes. Some implementations may choose to create a LabelProvider in a property source constructor, and if LabelProvider creates a new instance of an image, for example, you'd quickly run out of available handles.

LabelProvider has a dispose() method already, but it is not possible to call it from IPropertySource for clean up. In fact, I don't think IPropertySource cleans up when it's no longer needed.
Comment 3 Eclipse Genie CLA 2019-03-30 15:19:26 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Lars Vogel CLA 2019-10-08 10:45:46 EDT
This bug was marked as stalebug a while ago. Marking as wontfix.

If this report is still relevant for the current release, please
reopen and remove the stalebug whiteboard tag.