Bugzilla – Full Text Bug Listing
| Summary: | [parser]Empty end tag is ignored in xml comment text if there is a jsp expression in the tag's attribute value | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Source Editing | Reporter: | Sarika Sinha <sarika.sinha> | ||||||
| Component: | jst.jsp | Assignee: | Sarika Sinha <sarika.sinha> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Nick Sandonato <nsand.dev> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | thatnitind | ||||||
| Version: | 3.2.2 | Flags: | nsand.dev:
review+
|
||||||
| Target Milestone: | 3.2.3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Created attachment 180472 [details]
Patch to correct the jsp translation inside xml comment
Tried lots of options to correct the empty end tag issue , then found that it happens only when the code is inside xml comment in script region. So corrected the jsp translation of xml comment. Added a junit for the same scenario.
Sarika, this patch is causing unit test failures in jsp.ui's test suite. Furthermore, it causes HTML-commented regions lose the ability to have content assist in scriptlets. Example: <html> <head> </head> <body> <!-- <% | %> --> </body> </html> Content assist and syntax highlighting are lost there. I think you're close though. Created attachment 181360 [details]
Patch to parse tags in xml comments
As XML comeents allows dynamic data to be parsed which can be part of xml tags, this patch parses xml tags inside xml comment. This enables the parsing of empty end tags and parses jsp expression correctly inside attribute value.
Patch looks good. Thanks, Sarika. |
Build Identifier: M20100818-0800 Following code gives error for missing end tag for cTag:getString: <script type="text/javascript"> <!-- if(confirm('<cTag:getString locale="${dayCellBean.locale}" key="INVOKE_CONFIRM_MSG" argument="<%= daycellBean.getDate() %>" />')) { } } //--> </script> Reproducible: Always