Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326192

Summary: [translation] JSP translation errors disappears after manual re validation
Product: [WebTools] WTP Source Editing Reporter: Sarika Sinha <sarika.sinha>
Component: jst.jspAssignee: jst.jsp <jst.jsp-inbox>
Status: REOPENED --- QA Contact: Nick Sandonato <nsand.dev>
Severity: normal    
Priority: P3 CC: mauromol, nsand.dev, thatnitind, zalapa
Version: 3.2.2Flags: nsand.dev: review-
Target Milestone: Future   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch to persist translation problems sarika.sinha: review?

Description Sarika Sinha CLA 2010-09-24 15:01:32 EDT
Build Identifier: M20100818-0800

When a jsp file has some translation errors, and we re validate it without any modification to the jsp file, all the jsp translation errors disappears. 

This happens because transaltion problems are not being persisted along with the JSPTranslator object. 

Working on the patch.

Reproducible: Always
Comment 1 Sarika Sinha CLA 2010-09-27 06:19:51 EDT
Created attachment 179616 [details]
Patch to persist translation problems

Currently the JSP translation problem were disappearing if i close the file and validate it from explorer menu. To solve this problem, have added the persisting of JSP Problems along with JSPTranslator object.
Comment 2 Nick Sandonato CLA 2010-11-17 14:16:23 EST
I cannot reproduce this issue. Even if we don't persist problems, every time the JSPJavaValidator runs it should be reconciling and collecting problems for the existing translation (regardless of if it's from disk or in memory).
Comment 3 Sarika Sinha CLA 2010-12-02 01:35:48 EST
Hi Nick, 
I am able to reproduce it now also. You take any jsp with parsing validation errors like missing end tag etc. You close the file from editor. And from the Project explorer right click on the file and validate. It will say the file is validated with no errors. And the errors will go off from Markers.
Comment 4 Sarika Sinha CLA 2010-12-03 05:45:53 EST
Able to reproduce in latest build with the given steps.
Comment 5 Mauro Molinari CLA 2011-10-17 09:18:18 EDT
I also saw this problem many times, but could not reproduce in a consistent way. Do you plan to review and apply Sarika's patch?
Comment 6 Salvador Zalapa CLA 2013-08-09 16:06:30 EDT
I already tied the described scenarios, but I was not able to reproduce this in Kepler. I vote to resolve this issue.