Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326159

Summary:

[design] click on part toolbar needs two clicks on an inactive part

Product:

[RT] RAP

Reporter:

Holger Staudacher <holger.staudacher>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

1.4

Target Milestone:

1.4 M3

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Proposed patch	none
Updated patch	none

Description Holger Staudacher

2010-09-24 10:45:35 EDT

If a part has a toolbar you need to click twice if the part is inactive. The first click activates the part and the second selects the ToolItem. The item should be clickable wether the part is active or inactive.

Comment 1 Ivan Furnadjiev

2010-09-30 04:05:43 EDT

Created attachment 179930 [details]
Proposed patch

Comment 2 Ivan Furnadjiev

2010-09-30 04:06:44 EDT

Holger, please review the patch.

Comment 3 Ivan Furnadjiev

2010-09-30 04:57:26 EDT

Created attachment 179934 [details]
Updated patch

Comment 4 Holger Staudacher

2010-09-30 09:25:43 EDT

Hi Ivan.
I think your patch solves the problem. But there is one thing we should be aware of. I talk about multiple views. I had no time to test it with multiple views but we need to before you commit the patch. If an action is set to visible for one view, it should be visible for all others with the same primary id. So, if you set one action to visible and switch the view, it should be visible on this view too. Maybe this will work out of the box with your solution.

Thanks for your work.

Regards Holger

Comment 5 Ivan Furnadjiev

2010-10-01 04:23:02 EDT

Just tested with multiple views and it works fine - make an action visible in one view, make it visible in all views with the same primary id. Applied patch to CVS HEAD.