Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326134

Summary: Content assist proposals are missing additional info
Product: [WebTools] JSDT Reporter: Jacek Pospychala <jacek.pospychala>
Component: WebAssignee: Jacek Pospychala <jacek.pospychala>
Status: RESOLVED FIXED QA Contact: Nitin Dahyabhai <thatnitind>
Severity: normal    
Priority: P3 CC: cmjaun
Version: 3.2Flags: cmjaun: review+
thatnitind: review+
Target Milestone: 3.2.3   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
patch thatnitind: iplog+

Description Jacek Pospychala CLA 2010-09-24 06:52:02 EDT
In HTML (or PHP) editor, JavaScript completion proposals are missing additional info with JSDoc - the yellowish tooltip window, that should normally show up on the right of completion proposals list.
Everything works fine in JavaScript editor.

The difference between those editors is that HTML editor uses JSDTCompletionProposals, whereas JS editor uses JavaCompletionProposals.
JSDTCompletionProposal extends JavaCompletionProposal, altough the additionalInfo is never set and super.additionalInfo is not used as well.
Comment 1 Jacek Pospychala CLA 2010-09-24 07:38:41 EDT
Created attachment 179515 [details]
patch

make JSDTCompletionProposal.getAdditionalProposalInfo(IProgressMonitor) work the same as JSDTCompletionProposal.getAdditionalProposalInfo()
Comment 2 Jacek Pospychala CLA 2010-09-24 07:39:18 EDT
Chris,
want to review? :-)
Comment 3 Chris Jaun CLA 2010-09-28 10:20:59 EDT
Looks good to me.

Will get Nitin's approval and check into 3.2.3 and HEAD.
Comment 4 Nitin Dahyabhai CLA 2010-09-28 17:29:28 EDT
Checked into maintenance and HEAD.  Thanks, Jacek!