Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326133

Summary: [ActivityD] Showing names of Control Nodes / Can't add MergeNode to ActivityNodes
Product: [Modeling] GMF-Tooling Reporter: Christian Waniek <chris.waniek>
Component: SamplesAssignee: Christian Waniek <chris.waniek>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Proposed patch for the def-project
none
Re-generated activity diagram plugin none

Description Christian Waniek CLA 2010-09-24 06:31:19 EDT
Build Identifier: 

This issue covers two problems:

1. 
You can't add a MergeNode to one of the following Nodes: StructuredActivitynode, LoopNode, ConditinalNode, ExpansionRegion.
The propsed patch solves this problem.

2.
A name, given to a Pseudo-State, isn't shown in the diagram. To get more understandable diargams, if a name is given, this name should be shown in the diagram. Maybe with another patch the activity diagrams could be enhanced with a filter, which can hide pseudostate names.

Reproducible: Always
Comment 1 Christian Waniek CLA 2010-09-24 06:32:14 EDT
Created attachment 179512 [details]
Proposed patch for the def-project
Comment 2 Christian Waniek CLA 2010-09-24 06:32:48 EDT
Created attachment 179513 [details]
Re-generated activity diagram plugin
Comment 3 Christian Waniek CLA 2010-09-24 06:53:57 EDT
Soory, Pseudostate isn't the right term in combination with activity diagrams. I'm talking abuot the following nodes: 
ActivityFinalNode
FlowFinalNode
IntialNode
MergeNode
DecisionNode
ForkNode
JoinNode
Comment 4 Christian Waniek CLA 2010-09-24 11:18:35 EDT
Comment on attachment 179512 [details]
Proposed patch for the def-project

This patch contains changes, made to the file
"activityDiagram_controlNodes.gmfgraph", which haven't already been made with
#326163. So if #326163 hasn't already been applied this patch has to be edited
manually.
Comment 5 Christian Waniek CLA 2011-01-17 08:30:07 EST
MergeNodes can now be added to ActivityPartitions

The names of all ControlNodes and the Activity Initial Node are now shown int he diagram. Later I will add functionaility to configure the visibility of these names.