Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326057

Summary: [TMF] Custom parser time stamp output format reverts to default on edit
Product: z_Archived Reporter: Patrick Tasse <patrick.tasse>
Component: LinuxToolsAssignee: Francois Chouinard <fchouinard>
Status: CLOSED FIXED QA Contact: Francois Chouinard <fchouinard>
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 301610    
Attachments:
Description Flags
Proposed patch on org.eclipse.linuxtools.tmf.ui.wizards none

Description Patrick Tasse CLA 2010-09-23 09:55:52 EDT 
Build Identifier: 

When editing a custom parser in the wizard, the time stamp output format reverts to the default value.

Reproducible: Always

Steps to Reproduce:
1. Create a new custom parser with a non-default Time Stamp format and save it
2. Edit the custom parser
3. The Time Stamp format reverts to the default of yyyy-MM-dd HH:mm:ss.SSS
Comment 1 Patrick Tasse CLA 2010-09-23 10:01:15 EDT 
Created attachment 179459 [details]
Proposed patch on org.eclipse.linuxtools.tmf.ui.wizards

When loading the edited custom parser definition values into the wizard fields, the modify listener of the Text widgets cause the definition to be overwritten with the default values in the validate() method. The solution is to wait until the definition is loaded before adding the modify listeners.

The patch also contains some minor editorial changes.

Legal Message: I, Patrick Tasse, declare that I developed attached code from
scratch, without referencing any 3rd party materials except material licensed
under the EPL. I am authorized by my employer to make this contribution under
the EPL.
Comment 2 Patrick Tasse CLA 2012-09-06 17:25:17 EDT 
This change was committed with bug 327265 and delivered in 0.8.0.
Comment 3 Jeff Johnston CLA 2012-09-28 13:38:41 EDT 
Comment on attachment 179459 [details]
Proposed patch on org.eclipse.linuxtools.tmf.ui.wizards

Fixed in another bug.