Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 326002

Summary: [ui] [admin] 2 menu entries for Preferences (one not working)
Product: [Eclipse Project] Equinox Reporter: DJ Houghton <dj.houghton>
Component: p2Assignee: DJ Houghton <dj.houghton>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: remy.suen, susan
Version: 3.7   
Target Milestone: 3.7 M3   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
patch
none
additional patch none

Description DJ Houghton CLA 2010-09-22 14:35:49 EDT 
In the latest agent download for the Mac, there are 2 menu entries for Preferences. One under a Window menu, and one under the Eclipse Provisioning menu. 

The first one works ok. The second one (which has a shortcut of Command-comma like in the SDK) does nothing.

The correct behaviour should be that there is only one menu entry, it is under the Eclipse Provisioning menu, it opens the preferences, and it has a Command-comma keyboard shortcut.
Comment 1 DJ Houghton CLA 2010-09-22 16:33:39 EDT 
Created attachment 179409 [details]
patch

There were a couple of problems here. I talked to ppl on the UI team and they pointed me to the advisors that we use in the IDE and I have adjusted our menu items to be only visible if the user is not on a Mac.

The reason that the App menu Prefs menu item didn't open the Prefs dialog was because the configuration was missing the ui.cocoa fragment. I have added this to the product file.

Also for code clean-up I have removed the config.ini from the project. It is not used anymore and was out of date... Andrew has modified PDE/Build's product builds to get the start levels from the product file.

I tested this on both WinXP and Mac.
Comment 2 DJ Houghton CLA 2010-09-22 16:35:20 EDT 
Patch released to HEAD.

Susan, I just added you to the CC list in case you saw code coming by and wanted to know where it came from and wanted to review it. (I'm not a UI dev so there might be a better way to do things!)
Comment 3 Remy Suen CLA 2010-09-22 16:45:42 EDT 
I wonder if it might be too aggressive to turn off the entire 'Window' menu on the Macs? Do we expect people to be contributing to the 'Window' menu in admin UI?
Comment 4 DJ Houghton CLA 2010-09-22 16:49:18 EDT 
Good point. I have a new patch in hand similar to the code changes around the "quit" item. I will test and then post.
Comment 5 DJ Houghton CLA 2010-09-22 16:53:31 EDT 
Created attachment 179415 [details]
additional patch

I've released this additional patch. Thanks, Remy.