Bug 325898

Description Baltasar Belyavsky 2010-09-21 15:44:45 EDT

Build Identifier: I20100608-0911, CDT 7.0

The "Manage Configurations" dialog (ManageConfigDialog class) is always opened with the workbench window's shell as its parent (from ManageConfigRunner class).  This works out fine when the dialog is opened through the C/C++ Projects view's context menu, but it's incorrect when it's opened from the project Properties dialog.  In the latter case, the Properties dialog's shell should be used as the parent.

This was caught by our automated GUI tests when running on Linux - the "Manage Configurations" dialog, when opened from the Properties dialog, sometimes ends up hiding behind the Properties dialog.  There is no way to get out of this situation without killing the workbench.

In ManageConfigRunner, instead of using IWorkbench.getActiveWorkbenchWindow().getShell(), consider using Display.getActiveShell() as the parent shell for ManageConfigDialog.

Reproducible: Always

Steps to Reproduce:
The more severe symptom, where the "Manage Configurations" dialog hides behind the Properties dialog, is hard to reproduce - we are able to reproduce it on Linux.  But the general problem can be reproduced as follows:

1. Right-click on any project and bring up its Properties dialog.
2. Go to the C/C++ Build property-page, and click on the "Manage Configurations" button.
3. When the "Manage Configurations" dialog opens, try clicking on the Workbench window's header.
-> The "Manage Configurations" dialog flickers -> correct.
4. Now try clicking on the Properties dialog.
-> The "Manage Configurations" dialog doesn't flicker -> incorrect.