Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325816

Summary: Views and editors on same part stack behaviours needs to be clearer ?
Product: [Eclipse Project] e4 Reporter: Hitesh <hsoliwal>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel, remy.suen, wim.jongman
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 321864    

Description Hitesh CLA 2010-09-21 03:54:02 EDT
I have been using this layout for a while now, mostly because of the abundant real estate I get with this. The change in e4 which enables views and editors to be stacked on same partstack does impact some existing  concepts of workbench such as visibility/enablement of actions and behaviour of some actions. For example, with this layout I unconsciously expect the views to participate in 'Forward' and 'Back' navigation (tool item) actions.
Comment 1 Lars Vogel CLA 2015-02-04 06:25:39 EST
We still consider the behavior of views and editors as difference. Move back and forward between editors should remain independent of the views.
Comment 2 Wim Jongman CLA 2015-02-04 10:18:29 EST
(In reply to Lars Vogel from comment #1)
> We still consider the behavior of views and editors as difference. Move back
> and forward between editors should remain independent of the views.

I would say that this is broken from a user POV. Is not intuitive nor user friendly. I suggest to keep it open/HELPWANTED.

Would be a nice contribution if this was fixed.
Comment 3 Lars Vogel CLA 2015-02-04 10:22:24 EST
(In reply to Wim Jongman from comment #2) 
> I would say that this is broken from a user POV. Is not intuitive nor user
> friendly. I suggest to keep it open/HELPWANTED.
> 
> Would be a nice contribution if this was fixed.

What should be fixed here Wim?
Comment 4 Wim Jongman CLA 2015-02-04 10:57:21 EST
(In reply to Lars Vogel from comment #3)

> What should be fixed here Wim?

If I'm not mistaken the request was specific to let the views in the editor part stack  play along with the forward/back buttons. There are probably other cases which are addressed by the subject "Views and editors on same part stack behavior needs to be clearer".
Comment 5 Lars Vogel CLA 2015-02-04 11:00:28 EST
(In reply to Wim Jongman from comment #4)
> (In reply to Lars Vogel from comment #3)
> 
> > What should be fixed here Wim?
> 
> If I'm not mistaken the request was specific to let the views in the editor
> part stack  play along with the forward/back buttons. There are probably
> other cases which are addressed by the subject "Views and editors on same
> part stack behavior needs to be clearer".

The "Last Edit Location" is specific for editors and I think it would be hugely confusing if it would include views. See http://help.eclipse.org/luna/index.jsp?topic=%2Forg.eclipse.platform.doc.user%2Ftips%2Fplatform_tips.html for a description of the functionality.
Comment 6 Wim Jongman CLA 2015-02-04 11:33:32 EST
(In reply to Lars Vogel from comment #5)

I think Hitesh mentioned Forward and Back (ALT/LEFT ALT/RIGHT) not specifically Last Edit Location. Please dock a view in the editor stack and see how confusing this becomes.
Comment 7 Lars Vogel CLA 2015-02-05 03:33:44 EST
(In reply to Wim Jongman from comment #6)
> (In reply to Lars Vogel from comment #5)
> 
> I think Hitesh mentioned Forward and Back (ALT/LEFT ALT/RIGHT) not
> specifically Last Edit Location. Please dock a view in the editor stack and
> see how confusing this becomes.

From the help: 

Workbench editors keep a navigation history. If  you open a second editor while you're editing, you can press Navigate > Backward (Alt+Left Arrow, or the Left arrow icon back arrow on the workbench toolbar) to go back to the last editor.
Comment 8 Wim Jongman CLA 2015-02-05 16:58:28 EST
(In reply to Lars Vogel from comment #7)
> 
> From the help: 
> 
> Workbench editors keep a navigation history. If  you open a second editor
> while you're editing, you can press Navigate > Backward (Alt+Left Arrow, or
> the Left arrow icon back arrow on the workbench toolbar) to go back to the
> last editor.

Yes, if this get fixed we must also update the help. ;)

Did you already try to dock a view in the editor stack and try ALT/LEFT ALT/RIGHT?
Comment 9 Lars Vogel CLA 2015-02-06 06:03:39 EST
(In reply to Wim Jongman from comment #8)
> Yes, if this get fixed we must also update the help. ;)
> 
> Did you already try to dock a view in the editor stack and try ALT/LEFT
> ALT/RIGHT?

ALT/LEFT and ALT/RIGHT works across stacks, which I like. Adding views to this would be confusing IMHO. I suggest that we agree, that we both disagree.