Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325803

Summary: NPE in org.eclipse.jst.jsp.core.internal.java.XMLJSPRegionHelper.decodeRemainingRegions(XMLJSPRegionHelper.java:278)
Product: [WebTools] WTP Source Editing Reporter: Gary Karasiuk <karasiuk>
Component: jst.jspAssignee: Nick Sandonato <nsand.dev>
Status: RESOLVED FIXED QA Contact: Nick Sandonato <nsand.dev>
Severity: normal    
Priority: P3 CC: ccc, thatnitind
Version: 3.0.5Flags: nsand.dev: review+
Target Milestone: 3.0.5 P   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch to add null check ccc: iplog+

Description Gary Karasiuk CLA 2010-09-20 18:01:07 EDT
While viewing a customer JSP file were are seeing an NPE. (I don't have the customers permission to attach the JSP file). I have attached a simple patch that adds a null check. Here is a stack trace.

java.lang.NullPointerException
	at org.eclipse.jst.jsp.core.internal.java.XMLJSPRegionHelper.decodeRemainingRegions(XMLJSPRegionHelper.java:278)
	at org.eclipse.jst.jsp.core.internal.java.XMLJSPRegionHelper.nodeParsed(XMLJSPRegionHelper.java:191)
	at org.eclipse.jst.jsp.core.internal.java.XMLJSPRegionHelper.forceParse(XMLJSPRegionHelper.java:112)
	at org.eclipse.jst.jsp.core.internal.java.JSPTranslator.decodeScriptBlock(JSPTranslator.java:1284)
	at org.eclipse.jst.jsp.core.internal.java.JSPTranslator.translateRegionContainer(JSPTranslator.java:1243)
	at org.eclipse.jst.jsp.core.internal.java.JSPTranslator.translate(JSPTranslator.java:1048)
	at org.eclipse.jst.jsp.core.internal.java.JSPTranslationAdapter.getJSPTranslation(JSPTranslationAdapter.java:127)
	at org.eclipse.jst.jsp.core.internal.validation.JSPJavaValidator.performValidation(JSPJavaValidator.java:286)
	at org.eclipse.jst.jsp.core.internal.validation.JSPJavaValidator.validateFile(JSPJavaValidator.java:335)
	at org.eclipse.jst.jsp.core.internal.validation.JSPValidator.validate(JSPValidator.java:196)
	at org.eclipse.wst.sse.ui.internal.reconcile.validator.ReconcileStepForValidator.validate(ReconcileStepForValidator.java:292)
	at org.eclipse.wst.sse.ui.internal.reconcile.validator.ReconcileStepForValidator.reconcileModel(ReconcileStepForValidator.java:258)
	at org.eclipse.jface.text.reconciler.AbstractReconcileStep.reconcile(AbstractReconcileStep.java:96)
	at org.eclipse.wst.sse.ui.internal.reconcile.validator.ValidatorStrategy.reconcile(ValidatorStrategy.java:229)
	at org.eclipse.wst.sse.ui.internal.reconcile.DocumentRegionProcessor.process(DocumentRegionProcessor.java:191)
	at org.eclipse.wst.sse.ui.internal.reconcile.StructuredRegionProcessor.process(StructuredRegionProcessor.java:252)
	at org.eclipse.wst.sse.ui.internal.reconcile.DirtyRegionProcessor.run(DirtyRegionProcessor.java:657)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
Comment 1 Gary Karasiuk CLA 2010-09-20 18:03:59 EDT
Created attachment 179288 [details]
patch to add null check
Comment 2 Nick Sandonato CLA 2010-09-21 13:22:11 EDT
Patch looks good and is straightforward.
Comment 3 Carl Anderson CLA 2010-10-06 12:26:18 EDT
Committed to R3_0_5_patches