Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325752

Summary:	[call hierarchy] Widget is disposed exception when closing view
Product:	[Eclipse Project] JDT	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Raksha Vasisht <raksha.vasisht>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	rthakkar
Version:	3.6
Target Milestone:	3.7 M3
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2010-09-20 09:24:23 EDT

3.7 M2.

1. open Call Hierarch on HashMap.clear()
2. close the Call Hierarchy view directly after it starts to populate
==>
 
!ENTRY org.eclipse.ui 4 0 2010-09-20 15:22:21.246
!MESSAGE Unhandled event loop exception
!STACK 0
org.eclipse.swt.SWTException: Failed to execute runnable (org.eclipse.swt.SWTException: Widget is disposed)
	at org.eclipse.swt.SWT.error(SWT.java:4083)
	at org.eclipse.swt.SWT.error(SWT.java:3998)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:137)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4041)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3660)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:621)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:576)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1409)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1385)
	at org.eclipse.core.launcher.Main.main(Main.java:34)
Caused by: org.eclipse.swt.SWTException: Widget is disposed
	at org.eclipse.swt.SWT.error(SWT.java:4083)
	at org.eclipse.swt.SWT.error(SWT.java:3998)
	at org.eclipse.swt.SWT.error(SWT.java:3969)
	at org.eclipse.swt.widgets.Widget.error(Widget.java:468)
	at org.eclipse.swt.widgets.Widget.checkWidget(Widget.java:340)
	at org.eclipse.swt.widgets.Tree.getSelection(Tree.java:3401)
	at org.eclipse.jface.viewers.TreeViewer.getSelection(TreeViewer.java:256)
	at org.eclipse.jface.viewers.TreeViewer.setSelection(TreeViewer.java:344)
	at org.eclipse.jface.viewers.AbstractTreeViewer.setSelectionToWidget(AbstractTreeViewer.java:2480)
	at org.eclipse.jface.viewers.AbstractTreeViewer.setSelectionToWidget(AbstractTreeViewer.java:2903)
	at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1429)
	at org.eclipse.jface.viewers.TreeViewer.preservingSelection(TreeViewer.java:403)
	at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1383)
	at org.eclipse.jface.viewers.StructuredViewer.refresh(StructuredViewer.java:1485)
	at org.eclipse.jface.viewers.ColumnViewer.refresh(ColumnViewer.java:537)
	at org.eclipse.jdt.internal.ui.callhierarchy.CallHierarchyContentProvider.collapseAndRefresh(CallHierarchyContentProvider.java:374)
	at org.eclipse.jdt.internal.ui.callhierarchy.DeferredMethodWrapper$1.run(DeferredMethodWrapper.java:86)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:134)
	... 24 more

Comment 1 Raksha Vasisht

2010-09-27 15:41:57 EDT

Fixed in HEAD in 

DeferredMethodWrapper$1.run()
CallHierarchyViewPart.dispose().

Comment 2 Dani Megert

2010-09-28 09:14:32 EDT

(In reply to comment #1)
> Fixed in HEAD in 
> 
> DeferredMethodWrapper$1.run()
> CallHierarchyViewPart.dispose().

This fix is working but it's not ideal.
1. we normally don't dispose PageBook since that's not needed
2. DeferredMethodWrapper$1.run() can check whether the viewer's control is
   disposed and hence there's no new method needed on the part

Adjusted code in HEAD accordingly.

Comment 3 Dani Megert

2010-10-26 04:43:12 EDT

Verified in I20101025-1800.

Comment 4 Rajesh

2010-10-26 09:18:29 EDT

Verified in I20101025-1800.