Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325722

Summary: 'Close'-related context menu actions should show up for all stacks and apply to all items
Product: [Eclipse Project] e4 Reporter: Hitesh <hsoliwal>
Component: UIAssignee: Remy Suen <remy.suen>
Status: VERIFIED FIXED QA Contact: Remy Suen <remy.suen>
Severity: normal    
Priority: P3 CC: bokowski, emoffatt, remy.suen
Version: 1.0   
Target Milestone: 4.1 M3   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 321864    

Description Hitesh CLA 2010-09-20 05:27:20 EDT 
See bug title ;)
Comment 1 Paul Webster CLA 2010-09-20 07:32:59 EDT 
Interesting.  We have Close Editor and Close Part as standard 3.x commands.  What should happen with them in if there's a view in the editor stack (when the view is active and when the view is inactive).

PW
Comment 2 Remy Suen CLA 2010-09-20 07:36:57 EDT 
I think these actions are useful generically and the context menu should appear for both the shared area and regular stacks.
Comment 3 Hitesh CLA 2010-09-20 07:45:32 EDT 
(In reply to comment #1 & #2)

'Close All' and 'Close Others' are desirable actions; I can think of 'Close Editors' and 'Close Views' as good additions (maybe as sub menuitems under a special menuitem, say 'Close Part').
Comment 4 Eric Moffatt CLA 2010-09-21 13:18:55 EDT 
Yes, I see something along these lines being better now that we're mixing views/editors.
Comment 5 Remy Suen CLA 2010-09-24 10:05:04 EDT 
(In reply to comment #1)
> We have Close Editor and Close Part as standard 3.x commands.

'Close Editor' and 'Close All Editors' is covered by scenario K in bug 321864. 'Close Part' should just close the active part, wherever it is. This is how it is in 3.x and is actually orthogonal to whether it is in the shared area or not.

(In reply to comment #3)
> 'Close All' and 'Close Others' are desirable actions;

I will implement this.

> I can think of 'Close
> Editors' and 'Close Views' as good additions (maybe as sub menuitems under a
> special menuitem, say 'Close Part').

We will use bug 326151 for deciding whether we want to move forward with this proposal or not.
Comment 6 Remy Suen CLA 2010-09-24 10:18:35 EDT 
Fixed in CVS HEAD.
Comment 7 Remy Suen CLA 2010-10-26 09:25:53 EDT 
Verified on Windows XP with I20101025-1602.