Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325702

Summary: Stack Overflow when using advices instead of advice
Product: [Modeling] M2T Reporter: Volker Wegert <eclipse>
Component: XpandAssignee: Project Inbox <m2t.xpand-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: btickets, karsten.thoms
Version: unspecifiedFlags: karsten.thoms: helios+
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Volker Wegert CLA 2010-09-19 13:49:10 EDT
Build Identifier: 20100617-1415

Note: This issue affects both Xpand and Xtend.

The documentation for both generator classes state that AOP advices have to be added using the syntax <advices value="my::Advices,my::Advices2"/>. This leads to an endless recursion because AbstractExpressionsUsingWorkflowComponent contains the following code:

	public void addAdvices(String advice) {
		addAdvices(advice);
	}

I assume that the method was intended to call addAdvice() instead (singular form). Changing the workflow file to <advice value="my::Advices,my::Advices2"/> fixes the issue for me, but I'd say that either the recursion should be fixed or the documentation should be updated.


Reproducible: Always
Comment 1 Karsten Thoms CLA 2011-08-23 15:23:15 EDT
This one was fixed on 2010-10-06

The implementation was changed to
	public void addAdvices(String advice) {
		addAdvice(advice);
	}
Comment 2 Karsten Thoms CLA 2013-02-21 08:12:26 EST
Bug resolved before Xpand 1.2 release date => Closing