Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325678

Summary:

edc - ARM - disassembly - check for alignment when disassembling instructions

Product:

[Tools] CDT

Reporter:

Kirk Beitz <kirk.beitz>

Component:

cdt-debug-edc

Assignee:

Ken Ryall <ken.ryall>

Status:

RESOLVED FIXED

QA Contact:

Ken Ryall <ken.ryall>

Severity:

normal

Priority:

Version:

7.0.1

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch for edc ARM to check for alignment	cdtdoug: iplog+

Description Kirk Beitz

2010-09-18 09:07:41 EDT

Created attachment 179173 [details]
patch for edc ARM to check for alignment

at times, the ARM disassembler would choke on code because the code being passed was not properly aligned, given odd-address requests by DisassemblyBackendDsf retrieveDisassembly().

the attached patch was formerly part of a much larger patch in Bug 325284, but has been extracted due to that bug relying on Bug 325277.  it represents the simplest patch to HEAD as of 2010.09.17 w.r.t. performing this functionality.

ARMDisassembly.java
- modified so that getModeAndRange() attempts to align based on information it
  gets from TargetEnvironmentARM regarding ARM or Thumb mode

TargetEnironmentARM.java
- modified to make a better last-ditch guess at ARM or Thumb based upon the
  alignment of the passed address.

this patch applies cleanly to head as of 2010.09.18; a modified version of the attached patch has been tested together with other disassembly changes, and is planned for later merge together at the same time.

Comment 1 Kirk Beitz

2010-10-06 22:45:45 EDT

resolved with 2010.oct.04 edc merge commits by ken.ryall@nokia.com