Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325627

Summary: API tests block with dialog
Product: [Eclipse Project] e4 Reporter: Paul Webster <pwebster>
Component: UIAssignee: Remy Suen <remy.suen>
Status: RESOLVED FIXED QA Contact: Remy Suen <remy.suen>
Severity: critical    
Priority: P3 CC: bokowski, emoffatt, remy.suen
Version: 1.0   
Target Milestone: 4.1 M3   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Saveable dialog none

Description Paul Webster CLA 2010-09-17 12:44:05 EDT
Created attachment 179133 [details]
Saveable dialog

While running org.eclipse.ui.tests.api.IViewPartTest.testOpenAndCloseSaveNotNeeded() it opens a dialog (it's not supposed to) and blocks the tests.
Comment 1 Remy Suen CLA 2010-09-17 12:45:39 EDT
*** Bug 325625 has been marked as a duplicate of this bug. ***
Comment 2 Remy Suen CLA 2010-09-17 12:57:52 EDT
From bug 325625 comment 1:
The part is hidden but when the window tries to close itself, we query for all
dirty parts and find this part so we try to prompt for a save.

----------

It seems to me that the EPS should explicitly invoke part.setDirty(false) when a part is hidden?
Comment 3 Remy Suen CLA 2010-09-20 12:21:17 EDT
Fixed in CVS HEAD.

(In reply to comment #2)
> It seems to me that the EPS should explicitly invoke part.setDirty(false) when
> a part is hidden?

In hindsight, this is a terribly dumb idea so I've done something else.