Bugzilla – Full Text Bug Listing
| Summary: | [Quick type hierarchy] Hide non implementing classes | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Marc-André Laperle <malaperle> | ||||||||||
| Component: | cdt-source-nav | Assignee: | Markus Schorn <mschorn.eclipse> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | Markus Schorn <mschorn.eclipse> | ||||||||||
| Severity: | enhancement | ||||||||||||
| Priority: | P3 | ||||||||||||
| Version: | 8.0 | ||||||||||||
| Target Milestone: | 8.0 | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 179577 [details]
Hide non implememting classes
This patch removes the nodes of non implementing classes. I'm not sure it's worth it to add an option for this. Any opinion?
Created attachment 179578 [details]
Test project
Created attachment 179579 [details]
Hide non implememting classes
(In reply to comment #1) > Created an attachment (id=179577) [details] > Hide non implememting classes > This patch removes the nodes of non implementing classes. I'm not sure it's > worth it to add an option for this. Any opinion? I don't think we need the option. Created attachment 179721 [details] Hide non-implementing leave nodes I have replaced your patch for the following reasons: * Your patch is incomplete (misses some change to THNode). * The model is used for both the type-hierarchy view and the quick type hierarchy. In the view, the non-implementors must not be removed. * I think the non-implementing leaves should be shown in the super-type hierarchy, which will be availabe with the implementation of bug 325488. Fixed in 8.0 > 20100928. *** cdt cvs genie on behalf of mschorn *** Bug 325623: Hide non-implementing leaves in quick type hierarchy. [*] THInformationControl.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/typehierarchy/THInformationControl.java?root=Tools_Project&r1=1.5&r2=1.6 [*] THHierarchyModel.java 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/typehierarchy/THHierarchyModel.java?root=Tools_Project&r1=1.16&r2=1.17 [*] THViewPart.java 1.21 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/typehierarchy/THViewPart.java?root=Tools_Project&r1=1.20&r2=1.21 [*] THNode.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt-core/org.eclipse.cdt.ui/src/org/eclipse/cdt/internal/ui/typehierarchy/THNode.java?root=Tools_Project&r1=1.7&r2=1.8 Thanks a lot Markus! |
When using quick type hierarchy on big hierarchies that only have some classes implementing/overriding the method of interest, it will display a lot of "grey" nodes of non implementing classes making it tedious to navigate. I suggest adding an option to hide the branches that do not contain any implementing classes. Small example: Class1 Class2 (green) Class3 (grey, hide it) Class4 (grey, hide it) Class5 (grey, hide it) Class6 (grey, don't hide it because of Class7) Class7 (green)