Bugzilla – Full Text Bug Listing
| Summary: | [Product Editor] Extend product definition format to allow mixed content (features and bundles) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Katya Stoycheva <katya.stoycheva> | ||||
| Component: | UI | Assignee: | Hannes Wellmann <wellmann.hannes1> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | curtis.windatt.public, daniel_megert, david_williams, gunnar, katya.stoycheva, Lars.Vogel, mdiggory, pascal, s.yousouf, t-oberlies, wellmann.hannes1 | ||||
| Version: | 4.0 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: | https://github.com/eclipse-pde/eclipse.pde/pull/291 | ||||||
| Whiteboard: | stalebug | ||||||
| Attachments: |
|
||||||
|
Description
Katya Stoycheva
Created attachment 179131 [details]
Repository to validate that a product containing both bundles and features could be installed properly (via P2 Director)
While we are at it I would also consider adding the possibility to list IUs, even if this is not supported by a full edition capability. I started a discussion on PDE dev ML http://dev.eclipse.org/mhonarc/lists/pde-dev/msg02016.html *** Bug 127814 has been marked as a duplicate of this bug. *** We (in p2) have already extended the product definition format so that the content of a product can be defined through features *and* bundles at the same time (bug 325622). The syntax we have chosen is adding a "type" attribute in the "product" tag with the three possible values "features", "bundles", and "mixed". If the type attribute is specified, it takes precedence over the "useFeatures" attribute. Is this extension reasonable? Will the PDE use the same format in case this enhancement is implemented? (In reply to comment #5) > Is this extension reasonable? Will the PDE use the same format in case this > enhancement is implemented? The change to the syntax sounds reasonable. I cannot say whether PDE would use the same format as there is currently no work being done on implementing it. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. If the bug is still relevant, please remove the "stalebug" whiteboard tag. This Bug is still relevant, as PDE should support for mixed products as well. When launching such a product, it can be a Feature-based launch where the specified Plug-ins are simply added as Additional Plug-ins. Besides that only the UI has to be prepared for the mixed case as well as the other few places that use `IProduct.useFeatures()`. Furthermore I suggest to replace the existing "useFeatures" attribute by the new "type" attribute P2 uses, when writing a product file. PDE would then only read a "useFeatures"-attribute to be backwards-compatible to existing products but would write the new attribute. Existing products will then be updated at the next modification. Cool, Hannes. This come up in almost every RCP training (why can't we mix features and plugins in the product) to which I explain that this was a design decision a long time ago and that most likely an alternative reality exists in which this was implemented differently. Looks like this will also soon show up in our reality. :-) Just created a PR to address this: https://github.com/eclipse-pde/eclipse.pde/pull/291 Everybody interested is invited to test it. The intention is to have this in the 2022-09 release. Will be delivered with Eclipse 4.29. |