Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325557

Summary: Associating a Launch with Perspective "None" is not persisted
Product: [Eclipse Project] Platform Reporter: Martin Oberhuber <mober.at+eclipse>
Component: DebugAssignee: Platform-Debug-Inbox <platform-debug-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: darin.eclipse, pawel.1.piech
Version: 3.6.1   
Target Milestone: 3.6.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch fixing the issue darin.eclipse: iplog+

Description Martin Oberhuber CLA 2010-09-17 05:16:21 EDT 
CQ:WIND00233281

Build ID: I20100608-0911 (Eclipse 3.6)

Steps to Reproduce:
1. Window > Preferences > Run/Debug > Perspectives
2. Pick any Launch type, change associated perspective for Debug 
   from "Debug" to "None", press OK
3. Quit and Restart --> Associated Perspective is back to "Debug"

This is a usability problem since in our product we have multiple perspectives tuned for debugging, which a user chooses before launching. Being thrown out of their chosen perspective on launch is perceived as disruptive.
Comment 1 Martin Oberhuber CLA 2010-10-11 08:13:17 EDT 
Created attachment 180595 [details]
Patch fixing the issue

Here is a patch fixing the issue, could this be considered?

Problem was that PerspectiveManager#generatePerspectiveXML() explicitly didn't persist the "None" setting. Now, the patch suppresses persisting the default perspective (which probably was the original intention of this code).
Comment 2 Darin Wright CLA 2010-10-15 10:58:21 EDT 
Comment on attachment 180595 [details]
Patch fixing the issue

Thanks for the patch. Applied.
Comment 3 Darin Wright CLA 2010-10-15 10:58:41 EDT 
Fixed.
Comment 4 Pawel Piech CLA 2010-10-15 11:09:10 EDT 
(In reply to comment #3)
> Fixed.

Thanks Darin, is it OK if I backport it to 3.6 stream?
Comment 5 Darin Wright CLA 2010-10-15 11:15:43 EDT 
(In reply to comment #4)
> (In reply to comment #3)
> > Fixed.
> Thanks Darin, is it OK if I backport it to 3.6 stream?

Sure. I guess you could clone this bug to keep track of it in 3.6.2, or just re-target this one for 3.6.2.
Comment 6 Pawel Piech CLA 2010-10-15 11:32:06 EDT 
I committed the fix for 3.6.2.