Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325556

Summary:

GDB 7.x MI thread details field ignored (DSF)

Product:

[Tools] CDT

Reporter:

John Dallaway <john>

Component:

cdt-debug-dsf-gdb

Assignee:

Marc Khouzam <marc.khouzam>

Status:

RESOLVED FIXED

QA Contact:

Marc Khouzam <marc.khouzam>

Severity:

normal

Priority:

CC:

pawel.1.piech

Version:

7.0

Target Milestone:

7.0.2

Hardware:

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

378152

Attachments:

Description	Flags
GDBProcesses_7_0-100917.patch	marc.khouzam: iplog+
Updated fix to not use Java 1.6 constructs	marc.khouzam: iplog-

Description John Dallaway

2010-09-17 05:03:35 EDT

Build Identifier: Eclipse 3.6.0 I20100608-0911 (with cdt_7_0 branch and CDT HEAD)

Many GDB servers provide thread information details which can be very useful to the developer. When debugging with GDB 6.x, CLIInfoThreadsInfo#parseThreadInfo() folds this extra information into the OS-specific thread ID for presentation to the user in the Debug view. When debugging with GDB 7.x, the information is made available by MIThread#getDetails() but this method is not used by the higher-level code.

Workaround: Type "info threads" in the GDB console to view the thread details.

Reproducible: Always

Comment 1 John Dallaway

2010-09-17 05:10:38 EDT

Created attachment 179092 [details]
GDBProcesses_7_0-100917.patch

This patch passes the GDB 7.x MI thread details into the MIThreadDMData object for presentation to the user within the Debug view. With this patch, the presentation of thread details in the Debug view matches that observed when using GDB 6.x. The patch should be usable for both CDT HEAD and the cdt_7_0 branch.

Comment 2 CDT Genie

2010-12-16 15:23:06 EST

*** cdt cvs genie on behalf of mkhouzam ***
Bug 325556: GDB 7.x MI thread details field ignored (DSF)

[*] GDBProcesses_7_0.java 1.21.2.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBProcesses_7_0.java?root=Tools_Project&r1=1.21.2.5&r2=1.21.2.6

Comment 3 Marc Khouzam

2010-12-16 15:36:37 EST

Created attachment 185366 [details]
Updated fix to not use Java 1.6 constructs

Small change to not use String.isEmpty()

Committed to HEAD and 7_0

John can you confirm it works as you expect?

Thanks for the contribution

Comment 4 Marc Khouzam

2010-12-16 15:53:47 EST

Fixed

Comment 5 CDT Genie

2010-12-16 16:23:02 EST

*** cdt cvs genie on behalf of mkhouzam ***
Bug 325556: GDB 7.x MI thread details field ignored (DSF)

[*] GDBProcesses_7_0.java 1.30 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBProcesses_7_0.java?root=Tools_Project&r1=1.29&r2=1.30

[*] MIThread.java 1.2.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/output/MIThread.java?root=Tools_Project&r1=1.2.2.1&r2=1.2.2.2

[*] GDBProcesses_7_0.java 1.21.2.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBProcesses_7_0.java?root=Tools_Project&r1=1.21.2.6&r2=1.21.2.7

Comment 6 John Dallaway

2010-12-17 11:56:33 EST

(In reply to comment #3)

> Committed to HEAD and 7_0
> 
> John can you confirm it works as you expect?

The final patch applied to the cdt_7_0 branch works well for me. Thank you.