Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325554

Summary:

JSP editor treated inclusion of an non-existing Servlet as valid, when a catch-all filter (*) is defined in web.xml

Product:

[WebTools] WTP Source Editing

Reporter:

K.Hollerith <khollerith.bugzilla>

Component:

jst.jsp

Assignee:

Nitin Dahyabhai <thatnitind>

Status:

RESOLVED FIXED

QA Contact:

Nick Sandonato <nsand.dev>

Severity:

minor

Priority:

CC:

thatnitind

Version:

unspecified

Flags:

nsand.dev: review+

Target Milestone:

3.2.3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
proposed patch	none

Description K.Hollerith

2010-09-17 04:43:01 EDT

Build Identifier: 3.6 - 20100617-1415 // WTP: 3.2.1

Bug 287128 checks the web.xml to validate <jsp:include>-Tags that include Servlets.
But it seems to be that also the <url-pattern> from a filter definition in the web.xml are used to validate Servlets.


Reproducible: Always

Steps to Reproduce:
1.Create a Project like in Bug 287128 (https://bugs.eclipse.org/bugs/show_bug.cgi?id=287128=
2.Add a catch-all Filter (url-pattern with /*) to the web.xml File:

<filter>
		<filter-name>TestFilter</filter-name>
		<filter-class>InvalidFilterClass</filter-class>
	</filter>
	<filter-mapping>
		<filter-name>TestFilter</filter-name>
		<url-pattern>/*</url-pattern>
	</filter-mapping>
3. Add a invalid jsp:include to your jsp-file:
<jsp:include page="/InvalidServlet" />
The invalid include is not market as a warning/error!

Comment 1 Nitin Dahyabhai

2011-01-13 00:18:28 EST

Created attachment 186705 [details]
proposed patch

Comment 2 Nitin Dahyabhai

2011-01-13 00:26:42 EST

Released