Bugzilla – Full Text Bug Listing
| Summary: | Import Plug-ins and fragments wizard "Target Definitions..." button | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Carolyn MacLeod <carolynmacleod4> | ||||||
| Component: | UI | Assignee: | Curtis Windatt <curtis.windatt.public> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | curtis.windatt.public | ||||||
| Version: | 3.7 | ||||||||
| Target Milestone: | 3.7 M4 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
The target definitions button opens the preference page. Not only does the second option deal with target definitions, but the first option as well. So even though the combo is disabled, it may still be helpful to have the button enabled. I can see this from both perspectives, but don't have a strong preference. OK, you can close if you like. I just wanted to point it out in case the button was only useful in the 2nd case.
Before you close, you might want to take a look at File->New->Java Project, and note that it uses Links ("Configure x...") to go to the preference page (instead of Buttons). It might be more consistent if you did the same?
Links are exactly what I was thinking. It would easily fit into the first line, though some users might not realize the link affects the contents of the target combo too (not a huge leap, but also not obvious). I'll mark for M3 to think about it, since the change is trivial. Fixed in HEAD. See PluginImportWizardFirstPage. I put a link at the top right instead of a button. The link is always enabled. Reopening, the fix never got committed so it is not in the M3 warmup builds. I don't have any changes in my workspace, so I have no idea what happened here. It looks like I may have to write the fix a second time. Created attachment 181980 [details]
Fix
Fixed in HEAD. Verified in I20101206-1800 |
Created attachment 179050 [details] screen snap of PluginImportWizardFirstPage Build id: I20100817-0800 Should the "Target Definitions..." button in the Import Plug-ins and fragments wizard be disabled when the "Target definition:" radio is not selected? I'm not sure, but I think it should be disabled when the targetDefinitionCombo is disabled? It may be confusing to the user to have it enabled - particularly to a screen reader user who cannot see that the corresponding combo is disabled.