Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325454

Summary:	Refactor TextLocation and EObjectAtOffsetHelper
Product:	[Modeling] TMF	Reporter:	Jan Koehnlein <jan>
Component:	Xtext	Assignee:	Jan Koehnlein <jan>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	tmf.xtext-inbox
Version:	2.0.0	Flags:	jan: indigo+
Target Milestone:	M2
Hardware:	All
OS:	All
Whiteboard:

Description Jan Koehnlein

2010-09-16 08:45:28 EDT

TextLocation
- it should be immutable
- it should rather be called TextRegion
- there should be a NULL literal to start a chain of merge operations

EObjectAtOffsetHelper
- should not be static
- rethink it's methods, as they are currently serving multiple purposes at once
- merge with ILocationInFileProvider

Comment 1 Jan Koehnlein

2010-09-17 04:39:51 EDT

Fixed in master, commit 840435da4d784c2735193dde3b9292801f9e09bd

I havent't merged EObjectAtOffsetHelper with LocationInFileProvider, as the latter already contains a lot of code.

Comment 2 Karsten Thoms

2017-09-19 15:50:07 EDT

Closing bug which were set to RESOLVED before Eclipse Neon.0.