Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325425

Summary:

natureEnablements is unnecessary synchronized (Nature Manager)

Product:

[Eclipse Project] Platform

Reporter:

Malgorzata Janczarska <malgorzata.tomczyk>

Component:

Resources

Assignee:

Malgorzata Janczarska <malgorzata.tomczyk>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Szymon.Brandys

Version:

3.7

Flags:

Szymon.Brandys: review+

Target Milestone:

3.7 M3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed patch	Szymon.Brandys: iplog+

Description Malgorzata Janczarska

2010-09-16 05:42:11 EDT

Build identifier: I20100912-2000

After fixing the bug 307587 all methods using natureEnablements map have been synchronized and the map was left redundantly synchronized. This leads to creating redundant locks each time natureEnablements is referenced.

Comment 1 Malgorzata Janczarska

2010-09-16 05:49:47 EDT

Created attachment 179009 [details]
Proposed patch

Comment 2 Szymon Brandys

2010-09-16 06:03:01 EDT

Thanks Gosia.

Comment 3 Szymon Brandys

2010-09-20 03:58:46 EDT

Checked in to HEAD.