Bugzilla – Full Text Bug Listing
| Summary: | [call hierarchy] Adjust Call Hierarchy view's label rendering to other views | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Dani Megert <daniel_megert> |
| Component: | UI | Assignee: | Raksha Vasisht <raksha.vasisht> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | trivial | ||
| Priority: | P3 | CC: | deepakazad, markus.kell.r, rthakkar |
| Version: | 3.7 | ||
| Target Milestone: | 3.7 M3 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
|
Description
Dani Megert
Fixed in HEAD. (In reply to comment #0) > Currently the CH starts to use '...' after three elements. We should change > this to start after two elements like in the Search or Type Hierarchy view. That part got fixed. However, if the string only shows a single element without any additional text then we don't need to put it in single quotes. Please revert that part of the change and also adjust the Type Hierarchy. (In reply to comment #2) > However, if the string only shows a single element without > any additional text then we don't need to put it in single quotes. Please > revert that part of the change and also adjust the Type Hierarchy. Fixed in HEAD for Call Hierarchy and Type Hierarchy. istoryAction_inputElements_1={0}
HistoryAction_inputElements_2={0}, {1}
HistoryAction_inputElements_more= {0}, {1}, ...
TypeHierarchyViewPart_inputElements_1= ''{0}''
TypeHierarchyViewPart_inputElements_2= ''{0}'', ''{1}''
TypeHierarchyViewPart_inputElements_more= ''{0}'', ''{1}'', ...
This looked strange too me and at a closer look we see that the old code is buggy since it combines the final strings in the code (see e.g. TypeHierarchyViewPart_ws_description). This is not good.
Raksha, can you please take care of this? Thanks.
I saw changes in HEAD in: /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/CallHierarchyMessages.properties /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyLifeCycle.java /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyMessages.java /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyMessages.properties (In reply to comment #4) > This looked strange too me and at a closer look we see that the old code is > buggy since it combines the final strings in the code (see e.g. > TypeHierarchyViewPart_ws_description). This is not good. > > Raksha, can you please take care of this? Thanks. Fixed in /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyLifeCycle.java /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyMessages.java /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyMessages.properties This is not fixed. You reverted to the broken state where the individual elements aren't in single quotes i.e. it now shows as 'a, b'. Also, you did not solve the problem I mentioned in comment 4: the strings are still concatenated in the code. (In reply to comment #7) > This is not fixed. You reverted to the broken state where the individual > elements aren't in single quotes i.e. it now shows as 'a, b'. Also, you did not > solve the problem I mentioned in comment 4: the strings are still concatenated > in the code. Fixed view description and tooltip in /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/HistoryAction.java /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyMessages.java /org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyMessages.properties Verified in I20101025-1800. |