Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325367

Summary:

[Net] Unnecessary double check bypass settings in AbstractProxyProvider.select(URI)

Product:

[Eclipse Project] Platform

Reporter:

Wojciech Galanciak <wojciech.galanciak>

Component:

Team

Assignee:

Platform Team Inbox <platform-team-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

Flags:

Szymon.Brandys: review+

Version:

3.6

Target Milestone:

3.7 M3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
initial patch	Szymon.Brandys: iplog+

Description Wojciech Galanciak

2010-09-15 11:25:50 EDT

Bug created for a problem mentioned in bug 323378 comment 3.

For Windows this code is unnecessary cause bypasses are checked again in ProxyBypass.bypassProxyFor(URI). With fix for bug 323378 it will support *.eclipse.org and eclipse.* patterns.

For Linux (without Gnome) this is the only place where bypasses are checked. In this case there is no support for bypasses with * on Linux (no Gnome).

For Gnome I will check native code if there is any method which checks bypasses. If not, the situation will be the same as in Linux without Gnome.

First possible solution is to add support for bypass patterns in AbstractProxyProvider. In this case bypass checking should be removed from WindowsProxyProvider.

The second one is to remove it from AbstractProxyProvider at all and move responsibility for that to UnixProxyProvider (the same approach as in Windows).

Comment 1 Wojciech Galanciak

2010-09-16 10:47:03 EDT

Created attachment 179037 [details]
initial patch

This patch moves responsibility for checking bypasses from AbstractProxyProvider to WindowsProxyProvider and UnixProxyProvider. It passes unit tests for Windows. To be sure that the patch is fully correct I need to check it also on Linux machine.

Comment 2 Szymon Brandys

2010-10-07 07:31:06 EDT

Looks good. Please verify on Linux though.