Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325087

Summary: Improve the behavior of the Criteria (Where clause) grid in the SQL Query Builder
Product: [Tools] Data Tools Reporter: Brian Payton <bpayton>
Component: SQL Query BuilderAssignee: Brian Payton <bpayton>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 1.8   
Target Milestone: 1.8.1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch for plugin o.e.d.sqltools.sqlbuilder none

Description Brian Payton CLA 2010-09-13 05:07:45 EDT 
The Criteria (Where clause) part of the SQL Query Builder UI has some very annoying behavior.  For example, if you have a statement with a Where clause like this:

  WHERE Col1 = 'Foo'

The Criteria grid has the three columns Column, Operator, and Value showing Col1, =, and 'Foo' respectively.  If you click on any of those columns in order to edit the value, the value disappears.  This is annoying for any of those columns but is particularly so in the case of the Value column, since you might want to edit the current value, for example changing 'Foo' to 'Foot'.  Since the value blanks out, you need to type the entire value again.

This becomes downright obnoxious if you have an EXISTS predicate.  The entire subquery of the EXISTS predicate goes in the Value column, but you can't edit it.  The user is forced to edit the expression in the SQL source view.
Comment 1 Brian Payton CLA 2010-09-13 05:38:45 EDT 
Created attachment 178727 [details]
Patch for plugin  o.e.d.sqltools.sqlbuilder
Comment 2 Brian Payton CLA 2010-09-13 05:40:55 EDT 
The patch corrects the problems described above.  It also fixes a problem in the Expression Builder in the "Case - Simple" page where an expression built for the case value clause was not delivered back to the Case Simple page, preventing the Finish button from getting enabled.
Comment 3 Brian Payton CLA 2010-09-13 05:45:31 EDT 
Checked in fix, tagged to v201009131745
Comment 4 Brian Payton CLA 2010-09-15 15:32:39 EDT 
Changing status to Resolved - Fixed