Bug 325076

Comment 1 Aurelien Pupier 2010-09-13 03:36:21 EDT

Created attachment 178718 [details]
A first implementation

This is a first implementation.
Not all is already tested.

Comment 2 Ketan Padegaonkar 2010-10-12 10:55:45 EDT

Aurelien,

Your patch so far looks good. Do you plan on adding support for more widgets in the future ?

Also in order to ensure that any further changes to swtbot do not break existing functionality, it is important to have tests which document this functionality.

I'm not unwilling to commit anything to trunk without a valid set of rigorous test cases.

Comment 3 Aurelien Pupier 2010-10-12 11:06:46 EDT

(In reply to comment #2)
> Aurelien,
> 
> Your patch so far looks good. Do you plan on adding support for more widgets in
> the future ?

I think that it would be great to add support for the other Nebula widgets. If I can become comitter I'm sure that it would be easier to find more time to work on it :)

> 
> Also in order to ensure that any further changes to swtbot do not break
> existing functionality, it is important to have tests which document this
> functionality.
> 
> I'm not unwilling to commit anything to trunk without a valid set of rigorous
> test cases.

That is a good thing :)
I began to write test but there are not yet presentable in public.

Comment 4 Aurelien Pupier 2010-10-12 17:04:05 EDT

Created attachment 180712 [details]
implem and its tests

Implementation of SWTBot for Nebula Gallery and its tests

Comment 5 Aurelien Pupier 2011-09-17 10:59:47 EDT

Created attachment 203540 [details]
More complete implementation and its tests

Add implementation to select by Text (and their tests)

Comment 6 Ketan Padegaonkar 2011-09-26 12:28:47 EDT

(In reply to comment #4)
> Created attachment 180712 [details]
> implem and its tests
> 
> Implementation of SWTBot for Nebula Gallery and its tests

I am about to submit this to the legal team for review. They'll eventually have me ask you the following questions.

a) Have you authored 100% of the content being contributed? 

In any case, please list all author's names, organization, email address and/or phone number, percent of contribution authored.

b) Do you have the rights to contribute this content to Eclipse?

c) Are you willing to contribute this content and make it available under the Eclipse Public License (EPL)? Every source file would need a EPL header.

See EPL details here: http://www.eclipse.org/org/documents/epl-v10.php

Comment 7 Ketan Padegaonkar 2011-09-26 12:37:28 EDT

(In reply to comment #5)
> Created attachment 203540 [details]
> More complete implementation and its tests
> 
> Add implementation to select by Text (and their tests)

Just to be sure, does BonitaSoft have any kind of contribution agreements that'll speed this process up?

I'll promise to add you as a committer once you start contributing more content to nebula support :)

Comment 8 Ketan Padegaonkar 2011-09-26 12:42:26 EDT

Opened CQ 5625 to get this contribution into the repository.

Comment 9 Chris Aniszczyk 2011-09-26 19:45:09 EDT

Sounds like a potential new committer!

Comment 10 Aurelien Pupier 2011-09-27 03:39:45 EDT

(In reply to comment #6)
> (In reply to comment #4)
> > Created attachment 180712 [details] [details]
> > implem and its tests
> > 
> > Implementation of SWTBot for Nebula Gallery and its tests
> 
> I am about to submit this to the legal team for review. They'll eventually have
> me ask you the following questions.
> 
> a) Have you authored 100% of the content being contributed?

Yes

> 
> In any case, please list all author's names, organization, email address and/or
> phone number, percent of contribution authored.
> 
> b) Do you have the rights to contribute this content to Eclipse?
> 

Yes

> c) Are you willing to contribute this content and make it available under the
> Eclipse Public License (EPL)? Every source file would need a EPL header.
> 
> See EPL details here: http://www.eclipse.org/org/documents/epl-v10.php
 
Yes

Comment 11 Aurelien Pupier 2011-09-27 03:40:49 EDT

(In reply to comment #7)
> (In reply to comment #5)
> > Created attachment 203540 [details] [details]
> > More complete implementation and its tests
> > 
> > Add implementation to select by Text (and their tests)
> 
> Just to be sure, does BonitaSoft have any kind of contribution agreements
> that'll speed this process up?

I think yes, I'm committer on GMF-Runtime.

> 
> I'll promise to add you as a committer once you start contributing more content
> to nebula support :)

Good to know :)

Comment 12 tom xinhong 2012-04-01 11:27:47 EDT

I want to do some work for SWTBot to help it support more Nebula widgets in Google Summer of Code 2012, does anyone has interest to mentor this proposal/project?

Comment 13 Mickael Istria 2013-05-30 03:41:31 EDT

Aurelien, can you please turn your contribution as a Gerrit review? That would help me a lot to get it integrated.
FYI, I plan to release SWTBot within next month, it would be awesome if we could get it into this next SWTBot release.
http://wiki.eclipse.org/SWTBot/Contributing#Provide_a_contribution_using_Gerrit

Comment 14 Mickael Istria 2014-06-23 05:38:24 EDT

Up!
Aurelien, do you think you could use Gerrit to submit this contribution?

Comment 15 Mickael Istria 2014-07-01 11:45:34 EDT

Merged. Thanks for this contribution!