Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 325066

Summary:	reconsider customizeAccessRules
Product:	[WebTools] WTP Releng	Reporter:	David Williams <david_williams>
Component:	releng	Assignee:	webtools.releng <webtools.releng-inbox>
Status:	RESOLVED FIXED	QA Contact:	David Williams <david_williams>
Severity:	normal
Priority:	P3
Version:	3.10
Target Milestone:	3.10.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description David Williams

2010-09-12 23:37:10 EDT

In WTP builds, we have long had a custom task to take into account how a project had set their access rules. See 
http://wiki.eclipse.org/WTP:_Consumer_Control_of_Access_Rules

The purpose of this was so that WTP committers, as consumers of other parts of WTP, could "permit" themselves to use other parts of WTP without warning, so there would be no warnings about "discouraged access" for other WTP projects, with the whole goal of focusing attention on "discouraged access" from non-WTP projects (which are much more serious). 

I think its time to reconsider. I don't think anyone is particularly making use of this nice feature ... and it does add a little overhead to the build, Not much, but maybe 20 minutes of a 2 hour build, so worth reconsidering, if it is not being useful. 

As a first step, I'll simply remove the "defaults" of "org.eclipse.wst.*" and "org.eclipse.jst.*". 

Then later (a few days? weeks?) I'll add a variable so it can be turned on or off for any particular build or component, and set the default to off. 

And see if anyone notices . :) 

Perhaps more "friend" relationships should be defined? Across WTP projects?

Comment 1 David Williams

2011-03-05 21:20:14 EST

I've refactored stuff, and added a variable, and now default is "off". 

Should save a few minutes. 

Currently the variable 
customizeAccessRules 
would have to be defined in build.cfg (or, not sure, build.properties might work?) 
We can make or test this to be more refined later, if anyone wants it turned back on, so it can be controlled component by component.