Bug 325004

Comment 1 Wayne Beaton 2011-05-19 14:36:22 EDT

No traction. I have removed the blocker on Bug 342328.

Comment 2 Wayne Beaton 2011-10-24 16:40:42 EDT

Assigning to AC for their input.

Comment 3 John Arthorne 2013-08-21 13:46:17 EDT

Well if promotion reviews never happen it seems like something to just remove from the dev process entirely. I suppose what really happens here is a Creation Review for a new project, and a Restructuring Review to move code into it. Since any set of reviews can be combined (section 6.3.9) it can be done together already if that makes sense. So I think Promotion Review can be removed as a specific concept without losing anything of value.

Comment 4 Wayne Beaton 2013-08-21 13:53:51 EDT

(In reply to comment #3)
> Well if promotion reviews never happen it seems like something to just
> remove from the dev process entirely. I suppose what really happens here is
> a Creation Review for a new project, and a Restructuring Review to move code
> into it. Since any set of reviews can be combined (section 6.3.9) it can be
> done together already if that makes sense. So I think Promotion Review can
> be removed as a specific concept without losing anything of value.

Mylyn was the last project to "promote" to top-level. In the case of Mylyn, the Board approved the charter to create the top-level project and we did a restructuring review to move all the necessary bits. So it's certainly the case that a Restructuring review is probably all that we need.

Comment 5 John Arthorne 2013-08-21 13:56:56 EDT

Widening this a bit, we currently have 8 review types defined:

    6.3.1 Creation Review
    6.3.2 Graduation Review
    6.3.3 Release Review
    6.3.4 Promotion Review
    6.3.5 Continuation Review
    6.3.6 Termination Review
    6.3.7 Move Review
    6.3.8 Restructuring Review


This feels like a bewildering amount of process, and I don't think many people have really understood what these mean. I think we could boil this down to 5:

Creation Review
Graduation Review
Release Review
Termination Review
Restructuring Review

And we would maintain the concept of Combining Reviews to give flexibility.

Comment 6 Wayne Beaton 2013-08-21 14:25:18 EDT

(In reply to comment #5)
> This feels like a bewildering amount of process, and I don't think many
> people have really understood what these mean. I think we could boil this
> down to 5:
> 
> Creation Review
> Graduation Review
> Release Review
> Termination Review
> Restructuring Review
> 
> And we would maintain the concept of Combining Reviews to give flexibility.

+1

Comment 7 Wayne Beaton 2013-08-21 15:46:04 EDT

The line "All Projects are required to participate in at least one Review per year." from section 6.3 should be removed.

Comment 8 Wayne Beaton 2013-09-05 10:43:02 EDT

I have eliminated promotion, move, and continuation reviews from the document.

Since links to these sections may exist, I have left the section titles in the document, but have changed them to "[Reserved]"

(In reply to comment #7)
> The line "All Projects are required to participate in at least one Review per
> year." from section 6.3 should be removed.

Gone.