Bugzilla – Full Text Bug Listing
| Summary: | Perspective reset needs to be reexamined | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Remy Suen <remy.suen> | ||||||
| Component: | UI | Assignee: | Project Inbox <e4.ui-inbox> | ||||||
| Status: | RESOLVED WORKSFORME | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | Lars.Vogel | ||||||
| Version: | 1.0 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Remy Suen
At the moment, we destroy the perspective and then recreate it. We could invert the process which would correct the problem though it may be worth considering whether this is the right way to implement a perspective reset. Another suggestion from Remy was to *not* destroy/remove the MPerspective but destroy/re-create its internal structure. I think that this is the way I'll try to go here since it'll also 'fix' the current issue where a reset changes the order in the PerspectiveSwitcher... Created attachment 178938 [details]
Make resetPerspective really do a reset (rather then close/open)
This has a number of advantages over the old code:
- We re-use the *same* MPerspective (i.e. it's a true 'reset'). This reduces churn all around since the perspective has a context...
- Eliminates a really nasty issue with resetting when there's only the one perspective open; *every* shared part and open editor was destroyed (when we closed the last perspective) and recreated.
- Now the perspective switcher's items stay where they are on a reset (they used to be moved to the end of the TB).
Committed in >20100915. Applied the patch. Created attachment 178970 [details]
Clean up the 'transient' elements of a perspective on a reset
During a reset we still have to close and remove any minimized stack's MToolControls and any DW's.
Committed in >20100915. Applied the patch. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. No further work is planned here. |